[GitHub] [druid] chenyuzhi459 commented on pull request #10921: fix 'is not null' is invalid for array-type in druid-sql

[GitBox <gi...@apache.org>]

chenyuzhi459 commented on pull request #10921:
URL: https://github.com/apache/druid/pull/10921#issuecomment-788634853


   >  thanks for the fix, this was my bad I think 
   > 
   > Any chance you could add a test for this case? https://github.com/apache/druid/blob/master/sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java is the catch-all bucket where we typically add functional query tests, and https://github.com/apache/druid/blob/master/sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTests.java is where you can find the data that these tests operate on, if it helps.
   
   Hey, i had try to add a test in https://github.com/apache/druid/blob/master/sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java.
   However, I can not  simulate a filter of `string_array` column,because we treat `string_array` column as `string` column in the `org.apache.druid.sql.calcite.schema.DruidSchema.analysisToRowSignature()`. For example, `dim3` column in table 'foo' is a multivalue column, and in the schema ,it convert to a string column simply.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org