You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2013/05/06 13:16:46 UTC
[5/5] git commit: WICKET-4852 Do not set CSS class on the li > span
element for a feedback message
WICKET-4852 Do not set CSS class on the li > span element for a feedback message
Minor formatting improvements
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/4c43ad59
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/4c43ad59
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/4c43ad59
Branch: refs/heads/master
Commit: 4c43ad591c86e26d7b8dd7a3e82913313e7e7fa0
Parents: 27f753e
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Mon May 6 14:13:33 2013 +0300
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Mon May 6 14:16:08 2013 +0300
----------------------------------------------------------------------
.../wicket/markup/html/panel/FeedbackPanel.java | 2 +-
.../markup/html/panel/FeedbackPanelTest.java | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/4c43ad59/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java
index fd4b28d..968a93c 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/panel/FeedbackPanel.java
@@ -347,7 +347,7 @@ public class FeedbackPanel extends Panel implements IFeedback
* The model object of the item
* @return Container that holds components of the feedback MessageListView.
*/
- protected ListItem<FeedbackMessage> newMessageItem(int index, IModel<FeedbackMessage> itemModel){
+ protected ListItem<FeedbackMessage> newMessageItem(int index, IModel<FeedbackMessage> itemModel) {
return new ListItem<>(index, itemModel);
}
}
http://git-wip-us.apache.org/repos/asf/wicket/blob/4c43ad59/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/FeedbackPanelTest.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/FeedbackPanelTest.java b/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/FeedbackPanelTest.java
index 29a8aad..01cb2cf 100644
--- a/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/FeedbackPanelTest.java
+++ b/wicket-core/src/test/java/org/apache/wicket/markup/html/panel/FeedbackPanelTest.java
@@ -19,7 +19,6 @@ package org.apache.wicket.markup.html.panel;
import org.apache.wicket.Component;
import org.apache.wicket.MarkupContainer;
import org.apache.wicket.WicketTestCase;
-import org.apache.wicket.feedback.FencedFeedbackPanel;
import org.apache.wicket.markup.IMarkupResourceStreamProvider;
import org.apache.wicket.markup.html.WebPage;
import org.apache.wicket.markup.html.basic.Label;
@@ -34,9 +33,8 @@ import org.junit.Test;
*/
public class FeedbackPanelTest extends WicketTestCase
{
-
@Test
- public void testCssClassesOnFeedbackPanel() throws Exception{
+ public void testCssClassesOnFeedbackPanel() throws Exception {
TestPage testPage = new TestPage();
testPage.label.error("Error message");
testPage.label.info("Info message");
@@ -44,8 +42,7 @@ public class FeedbackPanelTest extends WicketTestCase
executeTest(testPage, "FeedbackPanelTest_cssClasses_expected.html");
}
-
- public static class TestPage extends WebPage implements IMarkupResourceStreamProvider
+ private static class TestPage extends WebPage implements IMarkupResourceStreamProvider
{
FeedbackPanel feedbackPanel;
Component label;