You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/08/25 20:03:38 UTC
[GitHub] trafficserver pull request #927: TS-4785: Stale while revalidate plugin memo...
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/927
TS-4785: Stale while revalidate plugin memory corruption.
This fixes a couple of memory corruption bugs in the stale_while_revalidate
plugin.
First, when copying the client sockaddr, we need to copy the specific
address family structure, not the untyped struct sockaddr.
Next, we zero when allocating to make initialization more reliable.
Finally, we deal with receiving TS_EVENT_HTTP_CACHE_LOOKUP_COMPLETE
multiple times, which otherwise leads to a double free.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4785
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/927.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #927
----
commit 3ea1bce32312aa01f7d5501313622f88b2842fcd
Author: James Peach <jp...@apache.org>
Date: 2016-08-25T19:57:20Z
TS-4785: Stale while revalidate plugin memory corruption.
This fixes a couple of memory corruption bugs in the stale_while_revalidate
plugin.
First, when copying the client sockaddr, we need to copy the specific
address family structure, not the untyped struct sockaddr.
Next, we zero when allocating to make initialization more reliable.
Finally, we deal with receiving TS_EVENT_HTTP_CACHE_LOOKUP_COMPLETE
multiple times, which otherwise leads to a double free.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #927: TS-4785: Stale while revalidate plugin memory corr...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/927
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/510/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #927: TS-4785: Stale while revalidate plugin memory corr...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/927
/cc @PSUdaemon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #927: TS-4785: Stale while revalidate plugin memo...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/927
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #927: TS-4785: Stale while revalidate plugin memory corr...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/927
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/614/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #927: TS-4785: Stale while revalidate plugin memory corr...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on the issue:
https://github.com/apache/trafficserver/pull/927
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #927: TS-4785: Stale while revalidate plugin memory corr...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/927
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/616/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #927: TS-4785: Stale while revalidate plugin memory corr...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/927
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/512/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---