You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by phrocker <gi...@git.apache.org> on 2018/04/05 19:55:25 UTC

[GitHub] nifi-minifi-cpp pull request #293: MINIFICPP-445 Added escape/unescape CSV e...

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/293#discussion_r179582611
  
    --- Diff: libminifi/include/utils/StringUtils.h ---
    @@ -88,7 +91,10 @@ class StringUtils {
        */
       static inline bool equalsIgnoreCase(const std::string &left, const std::string right) {
         if (left.length() == right.length()) {
    -      return std::equal(right.begin(), right.end(), left.begin(), [](unsigned char lc, unsigned char rc) {return std::tolower(lc) == std::tolower(rc);});
    --- End diff --
    
    I noticed you changed a lot of files outside of core. Can you keep these at 200 characters so we avoid unnecessary change later?


---