[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #250: feat(apisix): allow extPlugins to be configured

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #250:
URL: https://github.com/apache/apisix-helm-chart/pull/250#discussion_r823511489



##########
File path: charts/apisix/values.yaml
##########
@@ -210,13 +210,19 @@ plugins:
   - traffic-split
   - gzip
   - real-ip
+  - ext-plugin-pre-req
+  - ext-plugin-post-req
 stream_plugins:
   - mqtt-proxy
   - ip-restriction
   - limit-conn
 
 pluginAttrs: {}
 
+extPlugin:
+  enabled: false
+  cmd: []

Review comment:
       Could you give some examples about `cmd`?

##########
File path: charts/apisix/README.md
##########
@@ -141,6 +141,14 @@ If etcd.enabled is true, set more values of bitnami/etcd helm chart use etcd as
 
 Default enabled plugins. See [configmap template](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/templates/configmap.yaml) for details.
 
+
+### extPlugin parameters

Review comment:
       ```suggestion
   ### external plugin parameters
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org