You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/13 11:33:03 UTC

[GitHub] [incubator-nuttx] rtucker85 opened a new pull request, #6062: SAM3X HSMCI DMA Fixes

rtucker85 opened a new pull request, #6062:
URL: https://github.com/apache/incubator-nuttx/pull/6062

   ## Summary
   
   1. Allow usage of DMA when SAM3X chips are selected.
   2. Configure HSMCI GPIOs when SAM3X chips are selected. 
   
   - In addition, some other minor fixes
   
   ## Impact
   SAM3x HSMCI DMA users
   
   ## Testing
   Compilation on the Arduino-Due target (arduino-due:nsh) with the following additional configuration options:
   CONFIG_MMCSD_SDIO=y
   CONFIG_SAM34_DMAC0=y
   CONFIG_SAM34_HSMCI=y
   CONFIG_SCHED_HPWORK=y
   CONFIG_SDIO_BLOCKSETUP=y
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6062: SAM3X HSMCI DMA Fixes

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6062:
URL: https://github.com/apache/incubator-nuttx/pull/6062


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6062: SAM3X HSMCI DMA Fixes

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6062:
URL: https://github.com/apache/incubator-nuttx/pull/6062#discussion_r850392284


##########
arch/arm/src/sam34/sam_hsmci.c:
##########
@@ -1800,6 +1802,9 @@ static int sam_sendcmd(FAR struct sdio_dev_s *dev,
          cmd, arg, regval);
   putreg32(regval, SAM_HSMCI_CMDR);
   sam_cmdsample1(SAMPLENDX_AFTER_CMDR);
+
+  nxsig_usleep(10);

Review Comment:
   In general it is good to know what is happening in the system. If you have it working with this delay I do not want to block changes from merge. Maybe adding some comment in code similar you posted here could be useful if somebody will ht any issue in the future and will decide to investigate it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] rtucker85 commented on a diff in pull request #6062: SAM3X HSMCI DMA Fixes

Posted by GitBox <gi...@apache.org>.
rtucker85 commented on code in PR #6062:
URL: https://github.com/apache/incubator-nuttx/pull/6062#discussion_r850344894


##########
arch/arm/src/sam34/sam_hsmci.c:
##########
@@ -1800,6 +1802,9 @@ static int sam_sendcmd(FAR struct sdio_dev_s *dev,
          cmd, arg, regval);
   putreg32(regval, SAM_HSMCI_CMDR);
   sam_cmdsample1(SAMPLENDX_AFTER_CMDR);
+
+  nxsig_usleep(10);

Review Comment:
   In my testing, without the delay, card initialisation was unsuccessful.
   Card initialisation is successful when mcinfo is turned on. This is because of the added execution time to run mcinfo @ line 1801.
   Inserting the delay replicates this behaviour.
   
   It appears the timing between sam_sendcmd and sam_waitresponse is too short.
   
   Happy to investigate better ways to achieve this if you wish?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6062: SAM3X HSMCI DMA Fixes

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6062:
URL: https://github.com/apache/incubator-nuttx/pull/6062#discussion_r850433845


##########
arch/arm/src/sam34/sam_hsmci.c:
##########
@@ -1800,6 +1802,9 @@ static int sam_sendcmd(FAR struct sdio_dev_s *dev,
          cmd, arg, regval);
   putreg32(regval, SAM_HSMCI_CMDR);
   sam_cmdsample1(SAMPLENDX_AFTER_CMDR);
+
+  nxsig_usleep(10);

Review Comment:
   Thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6062: SAM3X HSMCI DMA Fixes

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6062:
URL: https://github.com/apache/incubator-nuttx/pull/6062#discussion_r849561094


##########
arch/arm/src/sam34/sam_hsmci.c:
##########
@@ -1800,6 +1802,9 @@ static int sam_sendcmd(FAR struct sdio_dev_s *dev,
          cmd, arg, regval);
   putreg32(regval, SAM_HSMCI_CMDR);
   sam_cmdsample1(SAMPLENDX_AFTER_CMDR);
+
+  nxsig_usleep(10);

Review Comment:
   Why do we need a sleep here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] rtucker85 commented on a diff in pull request #6062: SAM3X HSMCI DMA Fixes

Posted by GitBox <gi...@apache.org>.
rtucker85 commented on code in PR #6062:
URL: https://github.com/apache/incubator-nuttx/pull/6062#discussion_r850430280


##########
arch/arm/src/sam34/sam_hsmci.c:
##########
@@ -1800,6 +1802,9 @@ static int sam_sendcmd(FAR struct sdio_dev_s *dev,
          cmd, arg, regval);
   putreg32(regval, SAM_HSMCI_CMDR);
   sam_cmdsample1(SAMPLENDX_AFTER_CMDR);
+
+  nxsig_usleep(10);

Review Comment:
   Great idea. I have added a comment around this delay.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org