[jira] [Commented] (PHOENIX-6253) Change shaded connector jar naming convention

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257142#comment-17257142 ] 

ASF GitHub Bot commented on PHOENIX-6253:
-----------------------------------------

stoty commented on pull request #45:
URL: https://github.com/apache/phoenix-connectors/pull/45#issuecomment-753258480


   I think that we are breaking much more than this already, even without this patch.
   
   - We have completely removed the connectors from Phoenix proper, and moved them to a new project, so both the old maven coordinates, and the installed JAR locations are gone anyways.
   - All but the hive connectors were included in the phoenix-client JAR, and we told users to use that. The new phoenix-client JAR doesn't include them for obvious reasons, and I currently have no plans reintroduce a new uber-uber-jar to connectors, due to the shading issues that the old one has. (see PHOENIX-5202 )
   
   We will need update ALL connectors-related docs anyways.
   - Add a release note for core that points to the new -connectors (and -pqs repos)
   - Add/Update building docs for PQS and connectors, describing how the 4.x/master, Phoenix and HBase releases are handled.
   - Update the docs for each connector for the new repo and JARs / artifacts. 
   - The Spark connectors docs just plain don't work as written, and possibly never did.
   - The Hive connector has serious conflicts with the HBase 2.0.0-alpha included in Hive 3.1.2 (and also with the ancient Hbase in 2.4 for Phoenix 4.x), which requires either hacking up the binary hive distro, or rebuilding it from source with an unmerged patch (see  HIVE-24473), we'll also have to document that.
   
   However, I am not completely sure about the exact naming scheme in this PR, so if you'd prefer an alternative, I'd be happy to discuss that, even if keeping the old one is impossible.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Change shaded connector jar naming convention
> ---------------------------------------------
>
>                 Key: PHOENIX-6253
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6253
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: connectors
>    Affects Versions: connectors-6.0.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> Currently we distinguish the shaded and unshaded connector JARs by moving the version about. I.e phoenix5-hive-6.0.0 jar is the unshaded JAR, while phoenix5-6.0.0-hive.jar is the shaded one.
> This is unintuitive, and we have already dropped this convention in core.
> We could use something like:
> -phoenix5-spark-6.0.0.jar: the unshaded connector JAR-
> -phoenix5-spark-connector-6.0.0.jar : the default shaded connector JAR-
> -phoenix5-spark-connector-byo-hbase-6.0.0.jar : alternative shaded connector JAR.-
> phoenix5-spark-6.0.0.jar: the unshaded connector JAR
> phoenix5-spark-6.0.0-shaded.jar : the default shaded connector JAR
> phoenix5-spark-6.0.0-shaded-byo-hbase.jar : alternative shaded connector JAR.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)