You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/13 09:38:22 UTC
[GitHub] [beam] galuszkak opened a new pull request #12568: [BEAM-9456] Upgrade to Gradle 6.5.1
galuszkak opened a new pull request #12568:
URL: https://github.com/apache/beam/pull/12568
Upgrade to Gradle 6.5.1
There are probably some issues still with my PR as I'm not a Gradle expert.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] galuszkak commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
galuszkak commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-705397673
BEAM-9456 has been resolved, even if this PR wasn't merged. Should I create separate ticket to remove all DeprecationWarnings?
Should this PR be closed then and reopen new one on new ticket?
cc @runningcode @kennknowles @mxm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
runningcode commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-681866458
Hi! Are there any blockers here? I think this would really improve build feedback times if we can get this in.
Can we rebase the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682225856
# [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=h1) Report
> Merging [#12568](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/dc3144d54c1f2adcc4f71520d5c1468a4a48e735?el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12568 +/- ##
==========================================
+ Coverage 40.22% 40.30% +0.08%
==========================================
Files 454 451 -3
Lines 53670 53168 -502
==========================================
- Hits 21587 21429 -158
+ Misses 32083 31739 -344
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/testing/test\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3BpcGVsaW5lLnB5) | `58.92% <0.00%> (-10.72%)` | :arrow_down: |
| [.../runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3Rlc3RfY2FjaGVfbWFuYWdlci5weQ==) | `43.05% <0.00%> (-4.78%)` | :arrow_down: |
| [...n/apache\_beam/runners/interactive/cache\_manager.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoZV9tYW5hZ2VyLnB5) | `39.31% <0.00%> (-1.67%)` | :arrow_down: |
| [...eam/runners/interactive/caching/streaming\_cache.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoaW5nL3N0cmVhbWluZ19jYWNoZS5weQ==) | `24.89% <0.00%> (-0.96%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `76.80% <0.00%> (-0.33%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=footer). Last update [d89bbfa...e13cd86](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-705737074
I think it makes sense to have separate tickets for deprecation warnings. If there are a few categories, maybe a few tickets. This way we can do it in small pieces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] etiennestuder commented on a change in pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
etiennestuder commented on a change in pull request #12568:
URL: https://github.com/apache/beam/pull/12568#discussion_r478561792
##########
File path: settings.gradle
##########
@@ -16,8 +16,34 @@
* limitations under the License.
*/
+
+plugins {
+ id "com.gradle.enterprise" version "3.4"
+}
Review comment:
`apply false` ommitted on purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682225856
# [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request head (`feature/gradle-upgrade-6@93859c0`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-head-commit).
> The diff coverage is `n/a`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682104583
@kennknowles I will not have time to review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682225856
# [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request head (`feature/gradle-upgrade-6@93ec46b`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-head-commit).
> The diff coverage is `n/a`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] iemejia commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682411536
I am afraid I am in a similar position, I have already 5 pending reviews (one big as this one) + other compromises for the next days. Any other possible candidate for reviewing this sooner @kennknowles ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682225856
# [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=h1) Report
> Merging [#12568](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/dc3144d54c1f2adcc4f71520d5c1468a4a48e735?el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12568 +/- ##
==========================================
+ Coverage 40.22% 40.30% +0.08%
==========================================
Files 454 451 -3
Lines 53670 53168 -502
==========================================
- Hits 21587 21429 -158
+ Misses 32083 31739 -344
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/testing/test\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3BpcGVsaW5lLnB5) | `58.92% <0.00%> (-10.72%)` | :arrow_down: |
| [.../runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3Rlc3RfY2FjaGVfbWFuYWdlci5weQ==) | `43.05% <0.00%> (-4.78%)` | :arrow_down: |
| [...n/apache\_beam/runners/interactive/cache\_manager.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoZV9tYW5hZ2VyLnB5) | `39.31% <0.00%> (-1.67%)` | :arrow_down: |
| [...eam/runners/interactive/caching/streaming\_cache.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoaW5nL3N0cmVhbWluZ19jYWNoZS5weQ==) | `24.89% <0.00%> (-0.96%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `76.80% <0.00%> (-0.33%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=footer). Last update [d89bbfa...e13cd86](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] galuszkak commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
galuszkak commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-705397673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682225856
# [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=h1) Report
> Merging [#12568](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/faf76d59a5b24bf7f0daed5a503a07f0fff70ec1?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12568 +/- ##
=======================================
Coverage 40.30% 40.30%
=======================================
Files 451 451
Lines 53168 53168
=======================================
Hits 21429 21429
Misses 31739 31739
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=footer). Last update [d89bbfa...e13cd86](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] galuszkak commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
galuszkak commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682548362
@kennknowles I can do it in 2 phases, if you think is worth it. I just wanted to remove all deprecation warnings with an upgrade to Gradle 7.0.
I will prepare a smaller PR this weekend then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
runningcode commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-686313897
@galuszkak were you able to prepare a smaller PR over the weekend?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] galuszkak commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
galuszkak commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-686909249
@runningcode Yes I did, but I had still some issues I tried to resolve them today. I put PR here:
https://github.com/apache/beam/pull/12776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682225856
# [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=h1) Report
> Merging [#12568](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/dc3144d54c1f2adcc4f71520d5c1468a4a48e735?el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12568 +/- ##
==========================================
+ Coverage 40.22% 40.30% +0.08%
==========================================
Files 454 451 -3
Lines 53670 53168 -502
==========================================
- Hits 21587 21429 -158
+ Misses 32083 31739 -344
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/testing/test\_pipeline.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3BpcGVsaW5lLnB5) | `58.92% <0.00%> (-10.72%)` | :arrow_down: |
| [.../runners/interactive/testing/test\_cache\_manager.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL3Rlc3RfY2FjaGVfbWFuYWdlci5weQ==) | `43.05% <0.00%> (-4.78%)` | :arrow_down: |
| [...n/apache\_beam/runners/interactive/cache\_manager.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoZV9tYW5hZ2VyLnB5) | `39.31% <0.00%> (-1.67%)` | :arrow_down: |
| [...eam/runners/interactive/caching/streaming\_cache.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoaW5nL3N0cmVhbWluZ19jYWNoZS5weQ==) | `24.89% <0.00%> (-0.96%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `76.80% <0.00%> (-0.33%)` | :arrow_down: |
| [setup.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2V0dXAucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/portability/python\_urns.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcG9ydGFiaWxpdHkvcHl0aG9uX3VybnMucHk=) | `100.00% <0.00%> (ø)` | |
| [...apache\_beam/runners/portability/portable\_runner.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9wb3J0YWJsZV9ydW5uZXIucHk=) | `27.37% <0.00%> (ø)` | |
| [...eam/runners/portability/fn\_api\_runner/fn\_runner.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2ZuX3J1bm5lci5weQ==) | `24.52% <0.00%> (ø)` | |
| [sdks/python/apache\_beam/io/azure/blobstorageio.py](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vYXp1cmUvYmxvYnN0b3JhZ2Vpby5weQ==) | | |
| ... and [9 more](https://codecov.io/gh/apache/beam/pull/12568/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=footer). Last update [d89bbfa...e13cd86](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] galuszkak commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
galuszkak commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682012109
Hi @runningcode ,
There are still some changes that have to be fixed here. I plan to finish this over the weekend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682225856
# [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request head (`feature/gradle-upgrade-6@e13cd86`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-head-commit).
> The diff coverage is `n/a`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] galuszkak closed pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
galuszkak closed pull request #12568:
URL: https://github.com/apache/beam/pull/12568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-705737074
I think it makes sense to have separate tickets for deprecation warnings. If there are a few categories, maybe a few tickets. This way we can do it in small pieces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682511813
I was just tagging folks who I think have the best knowledge. It seems between these PRs we already have a number of people who know generally what needs to be done.
Judging by the other PR, maybe not everything here is mandatory for the upgrade? Then it could be quite a lot smaller, or broken into more commits. I have no problem with the change from `compile` to `implementation`, etc, but making sure we got everything and making sure nothing went wrong makes it a bit more work to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] galuszkak commented on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
galuszkak commented on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-706013098
Thanks @kennknowles. Alright I'm closing this one then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #12568: [BEAM-9456] Upgrade to Gradle 6.6.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #12568:
URL: https://github.com/apache/beam/pull/12568#issuecomment-682225856
# [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=h1) Report
> Merging [#12568](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/beam/commit/faf76d59a5b24bf7f0daed5a503a07f0fff70ec1?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12568 +/- ##
=======================================
Coverage 40.30% 40.30%
=======================================
Files 451 451
Lines 53168 53168
=======================================
Hits 21429 21429
Misses 31739 31739
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=footer). Last update [d89bbfa...e13cd86](https://codecov.io/gh/apache/beam/pull/12568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org