You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by zh...@apache.org on 2015/11/25 07:37:19 UTC

incubator-kylin git commit: KYLIN-1161 update url to fetch CubeInstance

Repository: incubator-kylin
Updated Branches:
  refs/heads/2.0-rc d19926353 -> 71be8b5f0


KYLIN-1161 update url to fetch CubeInstance


Project: http://git-wip-us.apache.org/repos/asf/incubator-kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kylin/commit/71be8b5f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kylin/tree/71be8b5f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kylin/diff/71be8b5f

Branch: refs/heads/2.0-rc
Commit: 71be8b5f0f21b6605ce7757ee1eb0425c4dc3d98
Parents: d199263
Author: Zhong <ji...@lm-shc-16501192.corp.ebay.com>
Authored: Wed Nov 25 14:34:02 2015 +0800
Committer: Zhong <ji...@lm-shc-16501192.corp.ebay.com>
Committed: Wed Nov 25 14:34:02 2015 +0800

----------------------------------------------------------------------
 .../java/org/apache/kylin/rest/controller/CubeController.java    | 4 ++--
 webapp/app/js/services/cubes.js                                  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/71be8b5f/server/src/main/java/org/apache/kylin/rest/controller/CubeController.java
----------------------------------------------------------------------
diff --git a/server/src/main/java/org/apache/kylin/rest/controller/CubeController.java b/server/src/main/java/org/apache/kylin/rest/controller/CubeController.java
index 7688260..52047ac 100644
--- a/server/src/main/java/org/apache/kylin/rest/controller/CubeController.java
+++ b/server/src/main/java/org/apache/kylin/rest/controller/CubeController.java
@@ -98,9 +98,9 @@ public class CubeController extends BasicController {
         return cubeService.getCubes(cubeName, projectName, modelName, limit, offset);
     }
 
-    @RequestMapping(value = "/get_cube", method = { RequestMethod.GET })
+    @RequestMapping(value = "/{cubeName}", method = { RequestMethod.GET })
     @ResponseBody
-    public CubeInstance getCube(@RequestParam(value = "cubeName", required = true) String cubeName) {
+    public CubeInstance getCube(@PathVariable String cubeName) {
         CubeInstance cube = cubeService.getCubeManager().getCube(cubeName);
         if (cube == null) {
             throw new InternalErrorException("Cannot find cube " + cubeName);

http://git-wip-us.apache.org/repos/asf/incubator-kylin/blob/71be8b5f/webapp/app/js/services/cubes.js
----------------------------------------------------------------------
diff --git a/webapp/app/js/services/cubes.js b/webapp/app/js/services/cubes.js
index 3dfd2c5..3df6dd0 100644
--- a/webapp/app/js/services/cubes.js
+++ b/webapp/app/js/services/cubes.js
@@ -19,7 +19,7 @@
 KylinApp.factory('CubeService', ['$resource', function ($resource, config) {
   return $resource(Config.service.url + 'cubes/:cubeId/:propName/:propValue/:action', {}, {
     list: {method: 'GET', params: {}, isArray: true},
-    getCube: {method: 'GET', params: {action:'get_cube'}, isArray: false},
+    getCube: {method: 'GET', params: {}, isArray: false},
     getSql: {method: 'GET', params: {propName: 'segs', action: 'sql'}, isArray: false},
     updateNotifyList: {method: 'PUT', params: {propName: 'notify_list'}, isArray: false},
     cost: {method: 'PUT', params: {action: 'cost'}, isArray: false},