[trafficserver] branch master updated: esi: remove unnecessary isCacheObjTransformable()

[ki...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

kichan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

The following commit(s) were added to refs/heads/master by this push:
       new  93186e2   esi: remove unnecessary isCacheObjTransformable()
93186e2 is described below

commit 93186e2b9dc7c59bdf9ad5e7fbca90f3c48c211a
Author: Liss Tarnell <ft...@le-Fay.ORG>
AuthorDate: Sun Jun 4 15:39:09 2017 +0100

    esi: remove unnecessary isCacheObjTransformable()
    
    This can never succeed, because in READ_RESPONSE_HDR there will not be a
    cached response.  Remove the call to prevent its error logging from
    filling the log.
---
 plugins/esi/esi.cc | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/plugins/esi/esi.cc b/plugins/esi/esi.cc
index 5dbbb22..de589ae 100644
--- a/plugins/esi/esi.cc
+++ b/plugins/esi/esi.cc
@@ -1522,13 +1522,7 @@ globalHookHandler(TSCont contp, TSEvent event, void *edata)
       if (event == TS_EVENT_HTTP_READ_RESPONSE_HDR) {
         bool mask_cache_headers = false;
         TSDebug(DEBUG_TAG, "[%s] handling read response header event", __FUNCTION__);
-        if (isCacheObjTransformable(txnp, &intercept_header, &head_only)) {
-          // transformable cache object will definitely have a
-          // transformation already as cache_lookup_complete would
-          // have been processed before this
-          TSDebug(DEBUG_TAG, "[%s] xform should already have been added on cache lookup. Not adding now", __FUNCTION__);
-          mask_cache_headers = true;
-        } else if (isTxnTransformable(txnp, false, &intercept_header, &head_only)) {
+        if (isTxnTransformable(txnp, false, &intercept_header, &head_only)) {
           addTransform(txnp, true, intercept_header, head_only, pOptionInfo);
           Stats::increment(Stats::N_OS_DOCS);
           mask_cache_headers = true;

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].