You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/12/23 06:18:44 UTC
[GitHub] [dubbo-go-hessian2] wongoo opened a new pull request #300: fix list value not unpacked
wongoo opened a new pull request #300:
URL: https://github.com/apache/dubbo-go-hessian2/pull/300
**What this PR does**:
fix list value not unpacked
**Which issue(s) this PR fixes**:
Fixes #299
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
```release-note
- fix list value not unpacked. #299
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #300: fix list value not unpacked
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #300:
URL: https://github.com/apache/dubbo-go-hessian2/pull/300#issuecomment-1000072500
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#300](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (608e492) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c715349dbc205aacf0dc3bd791e8e08b6d08cb4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c715349) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.33%`.
> :exclamation: Current head 608e492 differs from pull request most recent head cc52001. Consider uploading reports for the commit cc52001 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 70.70% 70.69% -0.01%
==========================================
Files 27 27
Lines 3021 3027 +6
==========================================
+ Hits 2136 2140 +4
- Misses 660 661 +1
- Partials 225 226 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [codec.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29kZWMuZ28=) | `74.67% <69.23%> (-0.90%)` | :arrow_down: |
| [java\_collection.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YV9jb2xsZWN0aW9uLmdv) | `60.56% <100.00%> (+1.65%)` | :arrow_up: |
| [list.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlzdC5nbw==) | `85.52% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c715349...cc52001](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #300: fix list value not unpacked
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #300:
URL: https://github.com/apache/dubbo-go-hessian2/pull/300#issuecomment-1000072500
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#300](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc52001) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c715349dbc205aacf0dc3bd791e8e08b6d08cb4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c715349) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.33%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 70.70% 70.69% -0.01%
==========================================
Files 27 27
Lines 3021 3027 +6
==========================================
+ Hits 2136 2140 +4
- Misses 660 661 +1
- Partials 225 226 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [codec.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29kZWMuZ28=) | `74.67% <69.23%> (-0.90%)` | :arrow_down: |
| [java\_collection.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YV9jb2xsZWN0aW9uLmdv) | `60.56% <100.00%> (+1.65%)` | :arrow_up: |
| [list.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlzdC5nbw==) | `85.52% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c715349...cc52001](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter commented on pull request #300: fix list value not unpacked
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #300:
URL: https://github.com/apache/dubbo-go-hessian2/pull/300#issuecomment-1000072500
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#300](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f9b351) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/c715349dbc205aacf0dc3bd791e8e08b6d08cb4e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c715349) will **decrease** coverage by `0.08%`.
> The diff coverage is `53.84%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
- Coverage 70.70% 70.62% -0.09%
==========================================
Files 27 27
Lines 3021 3033 +12
==========================================
+ Hits 2136 2142 +6
- Misses 660 664 +4
- Partials 225 227 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [codec.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29kZWMuZ28=) | `74.24% <50.00%> (-1.32%)` | :arrow_down: |
| [list.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlzdC5nbw==) | `85.52% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c715349...9f9b351](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/300?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo merged pull request #300: fix list value not unpacked
Posted by GitBox <gi...@apache.org>.
wongoo merged pull request #300:
URL: https://github.com/apache/dubbo-go-hessian2/pull/300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org