You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org> on 2019/01/05 02:54:48 UTC
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/
-----------------------------------------------------------
(Updated Jan. 5, 2019, 2:54 a.m.)
Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
Changes
-------
Added createTime in catalog as suggested.
Summary (updated)
-----------------
HIVE-21077 : Database and Catalogs should have creation time
Bugs: HIVE-21077
https://issues.apache.org/jira/browse/HIVE-21077
Repository: hive-git
Description (updated)
-------
HIVE-21077 : Database and Catalogs should have creation time
Diffs (updated)
-----
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 2953a8f327eabdee42dbc66e0c65f89d17add59a
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py f8b862862de4dde8dce3d0dc5f70eafb67b02d2c
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb dfc5d7b294c1df8d5c6b0e7d676a77ba1181e076
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 7d09a5c296a8ae924d61b200b4cb9135440fd9a0
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
Diff: https://reviews.apache.org/r/69664/diff/2/
Changes: https://reviews.apache.org/r/69664/diff/1-2/
Testing (updated)
-------
Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
Thanks,
Vihang Karajgaonkar
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
Posted by Karthik Manamcheri via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/#review212336
-----------------------------------------------------------
Ship it!
Ship It!
- Karthik Manamcheri
On Jan. 15, 2019, midnight, Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69664/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2019, midnight)
>
>
> Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
>
>
> Bugs: HIVE-21077
> https://issues.apache.org/jira/browse/HIVE-21077
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-21077 : Database and Catalogs should have creation time
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 13e287e352bdbfe5263b058e1b430af8613fe815
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 8f149d1d6e2a5b9571eeef3c05d68834e4035172
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb 9e5f0860f2b0e8caa9abf213e2a2c91b8e16d985
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 9576f8775a4a8a314e09462cbaaaeaebd3b4921f
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
> standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
> standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
> standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
> standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
> standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
> standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
> standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
> standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
> standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
> standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
> standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java bb20d9f42a855100397140f9e018c04c5f61dde7
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/TestSchemaToolForMetastore.java c2eb6c9e22a22f09cc1d2cc6394aa4e0e339b63a
>
>
> Diff: https://reviews.apache.org/r/69664/diff/7/
>
>
> Testing
> -------
>
> Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/
-----------------------------------------------------------
(Updated Jan. 15, 2019, midnight)
Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
Changes
-------
added suggested change by Bharath
Bugs: HIVE-21077
https://issues.apache.org/jira/browse/HIVE-21077
Repository: hive-git
Description
-------
HIVE-21077 : Database and Catalogs should have creation time
Diffs (updated)
-----
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 13e287e352bdbfe5263b058e1b430af8613fe815
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py 8f149d1d6e2a5b9571eeef3c05d68834e4035172
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb 9e5f0860f2b0e8caa9abf213e2a2c91b8e16d985
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 9576f8775a4a8a314e09462cbaaaeaebd3b4921f
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java bb20d9f42a855100397140f9e018c04c5f61dde7
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/TestSchemaToolForMetastore.java c2eb6c9e22a22f09cc1d2cc6394aa4e0e339b63a
Diff: https://reviews.apache.org/r/69664/diff/7/
Changes: https://reviews.apache.org/r/69664/diff/6-7/
Testing
-------
Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
Thanks,
Vihang Karajgaonkar
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
Posted by Bharathkrishna Guruvayoor Murali via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/#review211970
-----------------------------------------------------------
Fix it, then Ship it!
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
Lines 346 (patched)
<https://reviews.apache.org/r/69664/#comment297546>
nit : you can add the same comment added in the DB part.
// creation time of catalog in seconds since epoch
- Bharathkrishna Guruvayoor Murali
On Jan. 9, 2019, 6:50 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69664/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2019, 6:50 p.m.)
>
>
> Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
>
>
> Bugs: HIVE-21077
> https://issues.apache.org/jira/browse/HIVE-21077
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-21077 : Database and Catalogs should have creation time
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 2953a8f327eabdee42dbc66e0c65f89d17add59a
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py f8b862862de4dde8dce3d0dc5f70eafb67b02d2c
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb dfc5d7b294c1df8d5c6b0e7d676a77ba1181e076
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 7d09a5c296a8ae924d61b200b4cb9135440fd9a0
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
> standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
> standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
> standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
> standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
> standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
> standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
> standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
> standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
> standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
> standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
> standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java bb20d9f42a855100397140f9e018c04c5f61dde7
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/TestSchemaToolForMetastore.java c2eb6c9e22a22f09cc1d2cc6394aa4e0e339b63a
>
>
> Diff: https://reviews.apache.org/r/69664/diff/6/
>
>
> Testing
> -------
>
> Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/
-----------------------------------------------------------
(Updated Jan. 9, 2019, 6:50 p.m.)
Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
Changes
-------
Fixed TestCacheStore test failure
Bugs: HIVE-21077
https://issues.apache.org/jira/browse/HIVE-21077
Repository: hive-git
Description
-------
HIVE-21077 : Database and Catalogs should have creation time
Diffs (updated)
-----
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 2953a8f327eabdee42dbc66e0c65f89d17add59a
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py f8b862862de4dde8dce3d0dc5f70eafb67b02d2c
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb dfc5d7b294c1df8d5c6b0e7d676a77ba1181e076
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 7d09a5c296a8ae924d61b200b4cb9135440fd9a0
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java bb20d9f42a855100397140f9e018c04c5f61dde7
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/TestSchemaToolForMetastore.java c2eb6c9e22a22f09cc1d2cc6394aa4e0e339b63a
Diff: https://reviews.apache.org/r/69664/diff/6/
Changes: https://reviews.apache.org/r/69664/diff/5-6/
Testing
-------
Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
Thanks,
Vihang Karajgaonkar
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/
-----------------------------------------------------------
(Updated Jan. 9, 2019, 1:01 a.m.)
Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
Changes
-------
Fixed test failures.
Bugs: HIVE-21077
https://issues.apache.org/jira/browse/HIVE-21077
Repository: hive-git
Description
-------
HIVE-21077 : Database and Catalogs should have creation time
Diffs (updated)
-----
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 2953a8f327eabdee42dbc66e0c65f89d17add59a
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py f8b862862de4dde8dce3d0dc5f70eafb67b02d2c
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb dfc5d7b294c1df8d5c6b0e7d676a77ba1181e076
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 7d09a5c296a8ae924d61b200b4cb9135440fd9a0
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/tools/TestSchemaToolForMetastore.java c2eb6c9e22a22f09cc1d2cc6394aa4e0e339b63a
Diff: https://reviews.apache.org/r/69664/diff/4/
Changes: https://reviews.apache.org/r/69664/diff/3-4/
Testing
-------
Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
Thanks,
Vihang Karajgaonkar
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
> On Jan. 7, 2019, 8:28 p.m., Adam Holley wrote:
> > standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/69664/diff/3/?file=2118327#file2118327line137>
> >
> > nit: extraneous space.
The api/Catalog.java and api/Database.java are auto-generated files which cannot not be edited.
> On Jan. 7, 2019, 8:28 p.m., Adam Holley wrote:
> > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
> > Lines 1063 (patched)
> > <https://reviews.apache.org/r/69664/diff/3/?file=2118333#file2118333line1063>
> >
> > Need parenthesis around (System.currentTimeMillis() / 1000).
Thanks for catching this.
- Vihang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/#review211734
-----------------------------------------------------------
On Jan. 7, 2019, 7:16 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69664/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 7:16 p.m.)
>
>
> Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
>
>
> Bugs: HIVE-21077
> https://issues.apache.org/jira/browse/HIVE-21077
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-21077 : Database and Catalogs should have creation time
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 2953a8f327eabdee42dbc66e0c65f89d17add59a
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py f8b862862de4dde8dce3d0dc5f70eafb67b02d2c
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb dfc5d7b294c1df8d5c6b0e7d676a77ba1181e076
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 7d09a5c296a8ae924d61b200b4cb9135440fd9a0
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
> standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
> standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
> standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
> standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
> standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
> standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
> standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
> standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
> standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
> standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
> standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
>
>
> Diff: https://reviews.apache.org/r/69664/diff/3/
>
>
> Testing
> -------
>
> Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
Posted by Adam Holley via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/#review211734
-----------------------------------------------------------
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java
Lines 137 (patched)
<https://reviews.apache.org/r/69664/#comment297315>
nit: extraneous space.
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java
Lines 601 (patched)
<https://reviews.apache.org/r/69664/#comment297316>
nit: extraneous space.
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java
Lines 178 (patched)
<https://reviews.apache.org/r/69664/#comment297317>
nit: extraneous space
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 771 (patched)
<https://reviews.apache.org/r/69664/#comment297311>
Need parenthesis around the (System.currentTimeMillis() / 1000).
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 786 (patched)
<https://reviews.apache.org/r/69664/#comment297312>
Need parenthesis around (System.currentTimeMillis() / 1000).
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Lines 1063 (patched)
<https://reviews.apache.org/r/69664/#comment297313>
Need parenthesis around (System.currentTimeMillis() / 1000).
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
Line 1289 (original), 1293 (patched)
<https://reviews.apache.org/r/69664/#comment297314>
Need parenthesis around (System.currentTimeMillis() / 1000).
- Adam Holley
On Jan. 7, 2019, 7:16 p.m., Vihang Karajgaonkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69664/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2019, 7:16 p.m.)
>
>
> Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
>
>
> Bugs: HIVE-21077
> https://issues.apache.org/jira/browse/HIVE-21077
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-21077 : Database and Catalogs should have creation time
>
>
> Diffs
> -----
>
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
> standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
> standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 2953a8f327eabdee42dbc66e0c65f89d17add59a
> standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py f8b862862de4dde8dce3d0dc5f70eafb67b02d2c
> standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb dfc5d7b294c1df8d5c6b0e7d676a77ba1181e076
> standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 7d09a5c296a8ae924d61b200b4cb9135440fd9a0
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
> standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
> standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
> standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
> standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
> standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
> standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
> standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
> standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
> standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
> standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
> standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
> standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
> standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
>
>
> Diff: https://reviews.apache.org/r/69664/diff/3/
>
>
> Testing
> -------
>
> Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
>
>
> Thanks,
>
> Vihang Karajgaonkar
>
>
Re: Review Request 69664: HIVE-21077 : Database and Catalogs should
have creation time
Posted by Vihang Karajgaonkar via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69664/
-----------------------------------------------------------
(Updated Jan. 7, 2019, 7:16 p.m.)
Review request for hive, Karthik Manamcheri, Naveen Gangam, and Peter Vary.
Changes
-------
added create time to catalogs as well as suggested.
Bugs: HIVE-21077
https://issues.apache.org/jira/browse/HIVE-21077
Repository: hive-git
Description
-------
HIVE-21077 : Database and Catalogs should have creation time
Diffs (updated)
-----
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Catalog.java 3eb4dbd51110dd6e5d04c3bdacde2e5bdba09a7c
standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 994797698a379e0b08604d73d2d6728a2fcee4df
standalone-metastore/metastore-common/src/gen/thrift/gen-php/metastore/Types.php 2953a8f327eabdee42dbc66e0c65f89d17add59a
standalone-metastore/metastore-common/src/gen/thrift/gen-py/hive_metastore/ttypes.py f8b862862de4dde8dce3d0dc5f70eafb67b02d2c
standalone-metastore/metastore-common/src/gen/thrift/gen-rb/hive_metastore_types.rb dfc5d7b294c1df8d5c6b0e7d676a77ba1181e076
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift 7d09a5c296a8ae924d61b200b4cb9135440fd9a0
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a9398ae1e79404a15894aa42f451df5d18ed3e4c
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 58dc6eefcb840d4dd70af7a47811fab1b5e696d9
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java d43c0c1e70cffbebd39b05f89ec396227c58ac77
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/client/builder/DatabaseBuilder.java f3d2182a04ab81417a55554ba58d9340721513e8
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MCatalog.java e82cb4322f6e2ac7afeb5efcec7517a68c8b2dee
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/model/MDatabase.java 815b39c483b2233660310983d58194fb1ab2d107
standalone-metastore/metastore-server/src/main/resources/package.jdo caaec457194332a99d5cd57bef746e969dd38161
standalone-metastore/metastore-server/src/main/sql/derby/hive-schema-4.0.0.derby.sql a3c4196dbff7e53be5317631b314983d16a99020
standalone-metastore/metastore-server/src/main/sql/derby/upgrade-3.2.0-to-4.0.0.derby.sql bcaebd18accf86846ae44a6498046514575fc069
standalone-metastore/metastore-server/src/main/sql/mssql/hive-schema-4.0.0.mssql.sql 5ea1b4450d8258e841bb4af7381ca6fb0ba1a827
standalone-metastore/metastore-server/src/main/sql/mssql/upgrade-3.2.0-to-4.0.0.mssql.sql edde08db9ef7ee01800c7cc3a04c813014abdd18
standalone-metastore/metastore-server/src/main/sql/mysql/hive-schema-4.0.0.mysql.sql 5555a59c7d7e933d25d8d5af611e5b6aa0c0c19b
standalone-metastore/metastore-server/src/main/sql/mysql/upgrade-3.2.0-to-4.0.0.mysql.sql 701acb00984c61f7511dcc48053890b154575d1f
standalone-metastore/metastore-server/src/main/sql/oracle/hive-schema-4.0.0.oracle.sql b1980c5b83f16614845063516495188ebdd8c2a3
standalone-metastore/metastore-server/src/main/sql/oracle/upgrade-3.2.0-to-4.0.0.oracle.sql b9f63313251ab1fa6278b862ed9e07e62b234c04
standalone-metastore/metastore-server/src/main/sql/postgres/hive-schema-4.0.0.postgres.sql 9040005aa82b7a8cc5c01f257ecd47a7cc97e9b2
standalone-metastore/metastore-server/src/main/sql/postgres/upgrade-3.2.0-to-4.0.0.postgres.sql 0c36069d071d4b60cc338ba729da5d22e08ca8ca
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestCatalogs.java 28eb1fadca80dfd3c962e4163120b83f00410c4a
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java d323ac6c90ed20f092b4e179fdb1bed8602ecf63
Diff: https://reviews.apache.org/r/69664/diff/3/
Changes: https://reviews.apache.org/r/69664/diff/2-3/
Testing
-------
Ran ITests to check the db install and upgrade scripts are working for mysql, postgres, oracle and derby databases. The ITests for mssql is timing out for some reason due to container provisioning issues.
Thanks,
Vihang Karajgaonkar