You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/09/03 19:16:52 UTC
[jira] [Commented] (CB-7452) Windows. Rewrite
ApplyPlatformConfig.ps1 using NodeJS
[ https://issues.apache.org/jira/browse/CB-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120099#comment-14120099 ]
ASF GitHub Bot commented on CB-7452:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/42
CB-7452 Windows. Rewrite ApplyPlatformConfig.ps1 using NodeJS
https://issues.apache.org/jira/browse/CB-7452
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-7452
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 870ba746a977a1ef4433cb94ce3218024eae3351
Author: sgrebnov <v-...@microsoft.com>
Date: 2014-09-03T17:14:50Z
CB-7452 Windows. Rewrite ApplyPlatformConfig.ps1 using NodeJS
----
> Windows. Rewrite ApplyPlatformConfig.ps1 using NodeJS
> -----------------------------------------------------
>
> Key: CB-7452
> URL: https://issues.apache.org/jira/browse/CB-7452
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Affects Versions: 3.6.0
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: Windows
>
> We've recently switched to NodeJS tooling but still continue to use Powershell to perse config.xml and apply configuration params (ApplyPlatformConfig.ps1).
> I see the following motivation to re-write ApplyPlatformConfig using NodeJS.
> 1. More easy to contribute since most of Cordova contributors are experienced in Node and don't know PS
> 2. More easy to maintain and modify in the future, better integration with the rest of Node tooling
> 3. We already have most of the configuration processing logic for Windows in cordova-lib so switching to Node should be easy
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)