[GitHub] ivankelly opened a new pull request #1318: MockLedgerHandle duplicates LedgerEntries on read

[GitBox <gi...@apache.org>]

ivankelly opened a new pull request #1318: MockLedgerHandle duplicates LedgerEntries on read
URL: https://github.com/apache/bookkeeper/pull/1318
 
 
   Previously it was not duplicating, so the underlying ByteBuf was being
   returned to the client, and this was having its reader index modified,
   which meant that if it was read again, the data could not be read.
   
   By calling duplicate() on the LedgerEntryImpl, the underlying ByteBuf
   is sliced and retained, so it has a new set of indices. The retention
   does nothing, as the buffer is unpooled.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services