[jira] [Commented] (NUTCH-2600) Refactoring indexer-solr

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518876#comment-16518876 ] 

ASF GitHub Bot commented on NUTCH-2600:
---------------------------------------

r0ann3l opened a new pull request #351: fix for NUTCH-2600: Includes:
URL: https://github.com/apache/nutch/pull/351
 
 
   This patch includes an update for solrj library from version 5.5.0 to 7.3.1. According to [SOLR-8903](https://issues.apache.org/jira/browse/SOLR-8903), the lastest available version of this library doesn't include `DateUtil` class, so for formatting the dates I used `DateTimeFormatter.ISO_INSTANT.format(d.toInstant())` instead. In addition, the weight of a document is no longer supported by this library as an attribute of `SolrInputDocument` class and for that reason I include a new paramater: "weight.field", indicating the field's name where the document weight should be written. Also, Basic Authentication is now supported.
   
   On the other side, I refactored the code, deleting some unused constants, unsed parameters and including others in index-writers.xml.
   
   This PR was tested in Solr 6.3.0 and 7.3.1 in standalone and cloud mode. Basic Authentication was tested in these versions too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactoring indexer-solr
> ------------------------
>
>                 Key: NUTCH-2600
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2600
>             Project: Nutch
>          Issue Type: Improvement
>          Components: indexer, plugin
>    Affects Versions: 1.14
>            Reporter: Roannel Fernández Hernández
>            Priority: Minor
>             Fix For: 1.15
>
>
> indexer-solr includes an interface to define the parameters used by the plugin, however, in some cases this interface is not used and a string is used instead. Also, in index-writers.xml file, the commit.index parameter is never used in the code and the collection parameter is not included in index-writers.xml file.
> On the other hand, according to the configuration of indexer-solr plugin, it seems to support Basic Authentication but the username and password are never used. I don't know the reason for this, but I believe that it could be a good feature for Nutch and besides I think we should update Solrj library.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)