You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "bobhan1 (via GitHub)" <gi...@apache.org> on 2023/07/13 13:10:05 UTC

[GitHub] [doris] bobhan1 commented on a diff in pull request #21746: [feature](partial update) add failure tolerance for strict mode partial update stream load

bobhan1 commented on code in PR #21746:
URL: https://github.com/apache/doris/pull/21746#discussion_r1262536756


##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -364,6 +365,11 @@ Status SegmentWriter::append_block_with_partial_content(const vectorized::Block*
     }
     std::vector<std::unique_ptr<SegmentCacheHandle>> segment_caches(specified_rowsets.size());
     // locate rows in base data
+
+    int64_t num_rows_filtered = 0;
+
+    std::vector<size_t> delete_idx;

Review Comment:
   I forget to delete this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org