[jira] [Commented] (FLINK-19684) The Jdbc-connector's 'lookup.max-retries' option implementation is different from the meaning

["Jark Wu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-19684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215473#comment-17215473 ] 

Jark Wu commented on FLINK-19684:
---------------------------------

I think you are right. 

> The Jdbc-connector's  'lookup.max-retries' option implementation is different from the meaning
> ----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-19684
>                 URL: https://issues.apache.org/jira/browse/FLINK-19684
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / JDBC
>            Reporter: CaoZhen
>            Priority: Minor
>
>  
> The code of 'lookup.max-retries' option :
> {code:java}
> for (int retry = 1; retry <= maxRetryTimes; retry++) {
>       statement.clearParameters();
>       .....
> }  
> {code}
> From the code, If this option is set to 0, the JDBC query will not be executed.
>  
> From documents,  the max retry times if lookup database failed. [1]
> When set to 0, there is a query, but no retry.
>  
> So,the code of 'lookup.max-retries' option should be:
> {code:java}
> for (int retry = 0; retry <= maxRetryTimes; retry++) {
>       statement.clearParameters();
>       .....
> }  
> {code}
>  
>  
> [1] https://ci.apache.org/projects/flink/flink-docs-release-1.11/dev/table/connectors/jdbc.html#lookup-max-retries



--
This message was sent by Atlassian Jira
(v8.3.4#803005)