You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/02 12:33:27 UTC

[GitHub] [arrow] thisisnic commented on pull request #14553: ARROW-18203: [R] Refactor to remove unnecessary uses of build_expr

thisisnic commented on PR #14553:
URL: https://github.com/apache/arrow/pull/14553#issuecomment-1300303535

   > We could even move/rename it to Expression$op() to make clear that it is only for those operators, but I'm not sure that's necessary or helpful.
   
   I've skim-read this PR a few times now but failed to actually review it as I keep forgetting what the difference between `Expression$create()` and `build_expr()` is.  Now I've actually checked out this branch to see where we still use `build_expr()`, I think it'd make a lot of sense to rename it `Expression$op()` - I think this is a lot more intuitive.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org