You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/10/02 22:38:04 UTC

Review Request 26279: Replace some asserts with CHECKs in dispatch.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26279/
-----------------------------------------------------------

Review request for mesos and Ben Mahler.


Repository: mesos-git


Description
-------

replaced some system asserts with CHECK for better error logging


Diffs
-----

  3rdparty/libprocess/include/process/dispatch.hpp 88570f7c078faa7d79b2c187aa6a15e4e939878c 

Diff: https://reviews.apache.org/r/26279/diff/


Testing
-------

make check


Thanks,

Dominic Hamon


Re: Review Request 26279: Replace some asserts with CHECKs in dispatch.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26279/#review55247
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Oct. 2, 2014, 8:38 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26279/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2014, 8:38 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> replaced some system asserts with CHECK for better error logging
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/dispatch.hpp 88570f7c078faa7d79b2c187aa6a15e4e939878c 
> 
> Diff: https://reviews.apache.org/r/26279/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>