[GitHub] [hive] pkumarsinha commented on a change in pull request #2478: HIVE-25331: Create database query doesn't create MANAGEDLOCATION dire…

[GitBox <gi...@apache.org>]

pkumarsinha commented on a change in pull request #2478:
URL: https://github.com/apache/hive/pull/2478#discussion_r714488480



##########
File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosExclusiveReplica.java
##########
@@ -710,7 +710,6 @@ private void verifyCustomDBLocations(String srcDb, List<String> listOfTables, St
               replicatedDbName.toLowerCase()  + ".db").toUri().getPath());
     } else {
       Assert.assertNotEquals(managedCustLocOnSrc,  null);
-      Assert.assertEquals(replDatabase.getManagedLocationUri(),  null);

Review comment:
       @ujc714  Rather than removing, I think we should assert that replDatabase.getManagedLocationUri() is in default warehouse location, i.e it should be equal to new Path(replica.warehouseRoot, replicatedDbName.toLowerCase()  + ".db")




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org