You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Ben Frederickson (Created) (JIRA)" <ji...@apache.org> on 2012/01/17 19:22:42 UTC

[jira] [Created] (THRIFT-1491) Uninitialize processorFactory_ member in TServer.h

Uninitialize processorFactory_ member in TServer.h
--------------------------------------------------

                 Key: THRIFT-1491
                 URL: https://issues.apache.org/jira/browse/THRIFT-1491
             Project: Thrift
          Issue Type: Bug
          Components: C++ - Library
    Affects Versions: 0.9
         Environment: clang 3.0
            Reporter: Ben Frederickson
            Priority: Trivial
             Fix For: 0.9


In lib/cpp/src/server/TServer.h	there are two instances that the member 'processorFactory_' is initialized from itself.  This causes the following warnings in clang 3.0

/usr/local/include/thrift/server/TServer.h:147:23: error: field is uninitialized when used here
      [-Werror,-Wuninitialized]
    processorFactory_(processorFactory_) {
                      ^
/usr/local/include/thrift/server/TServer.h:230:23: error: field is uninitialized when used here
      [-Werror,-Wuninitialized]
    processorFactory_(processorFactory_),
                      ^


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1491) Uninitialize processorFactory_ member in TServer.h

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187998#comment-13187998 ] 

Hudson commented on THRIFT-1491:
--------------------------------

Integrated in Thrift #388 (See [https://builds.apache.org/job/Thrift/388/])
    THRIFT-1491 Uninitialize processorFactory_ member in TServer.h
Patch: Ben Frederickson

roger : http://svn.apache.org/viewvc/?view=rev&rev=1232544
Files : 
* /thrift/trunk/lib/cpp/src/server/TServer.h

                
> Uninitialize processorFactory_ member in TServer.h
> --------------------------------------------------
>
>                 Key: THRIFT-1491
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1491
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: clang 3.0
>            Reporter: Ben Frederickson
>            Priority: Trivial
>             Fix For: 0.9
>
>         Attachments: uninitialized_processorfactory_fix.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> In lib/cpp/src/server/TServer.h	there are two instances that the member 'processorFactory_' is initialized from itself.  This causes the following warnings in clang 3.0
> /usr/local/include/thrift/server/TServer.h:147:23: error: field is uninitialized when used here
>       [-Werror,-Wuninitialized]
>     processorFactory_(processorFactory_) {
>                       ^
> /usr/local/include/thrift/server/TServer.h:230:23: error: field is uninitialized when used here
>       [-Werror,-Wuninitialized]
>     processorFactory_(processorFactory_),
>                       ^

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (THRIFT-1491) Uninitialize processorFactory_ member in TServer.h

Posted by "Roger Meier (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roger Meier resolved THRIFT-1491.
---------------------------------

    Resolution: Fixed

Thanks Ben!
                
> Uninitialize processorFactory_ member in TServer.h
> --------------------------------------------------
>
>                 Key: THRIFT-1491
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1491
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: clang 3.0
>            Reporter: Ben Frederickson
>            Priority: Trivial
>             Fix For: 0.9
>
>         Attachments: uninitialized_processorfactory_fix.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> In lib/cpp/src/server/TServer.h	there are two instances that the member 'processorFactory_' is initialized from itself.  This causes the following warnings in clang 3.0
> /usr/local/include/thrift/server/TServer.h:147:23: error: field is uninitialized when used here
>       [-Werror,-Wuninitialized]
>     processorFactory_(processorFactory_) {
>                       ^
> /usr/local/include/thrift/server/TServer.h:230:23: error: field is uninitialized when used here
>       [-Werror,-Wuninitialized]
>     processorFactory_(processorFactory_),
>                       ^

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1491) Uninitialize processorFactory_ member in TServer.h

Posted by "Ben Frederickson (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Frederickson updated THRIFT-1491:
-------------------------------------

    Attachment: uninitialized_processorfactory_fix.patch

patch to fix
                
> Uninitialize processorFactory_ member in TServer.h
> --------------------------------------------------
>
>                 Key: THRIFT-1491
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1491
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: clang 3.0
>            Reporter: Ben Frederickson
>            Priority: Trivial
>             Fix For: 0.9
>
>         Attachments: uninitialized_processorfactory_fix.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> In lib/cpp/src/server/TServer.h	there are two instances that the member 'processorFactory_' is initialized from itself.  This causes the following warnings in clang 3.0
> /usr/local/include/thrift/server/TServer.h:147:23: error: field is uninitialized when used here
>       [-Werror,-Wuninitialized]
>     processorFactory_(processorFactory_) {
>                       ^
> /usr/local/include/thrift/server/TServer.h:230:23: error: field is uninitialized when used here
>       [-Werror,-Wuninitialized]
>     processorFactory_(processorFactory_),
>                       ^

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira