You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Kenneth Giusti <kg...@apache.org> on 2013/01/28 18:33:35 UTC
Review Request: [Proton] changes to support python 2.4
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9123/
-----------------------------------------------------------
Review request for qpid, Rafael Schloming and Philip Harvey.
Description
-------
Patch to support python 2.4.
This addresses bug proton-199.
https://issues.apache.org/jira/browse/proton-199
Diffs
-----
/proton/trunk/proton-c/bindings/python/proton.py 1439349
/proton/trunk/tests/proton_tests/common.py 1439349
Diff: https://reviews.apache.org/r/9123/diff/
Testing
-------
Tested on my Centos 5.9 i686 machine running python 2.4.3.
Thanks,
Kenneth Giusti
Re: Review Request: [Proton] changes to support python 2.4
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9123/#review15758
-----------------------------------------------------------
Ship it!
Ship It!
- Rafael Schloming
On Jan. 28, 2013, 5:33 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9123/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 5:33 p.m.)
>
>
> Review request for qpid, Rafael Schloming and Philip Harvey.
>
>
> Description
> -------
>
> Patch to support python 2.4.
>
>
> This addresses bug proton-199.
> https://issues.apache.org/jira/browse/proton-199
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/python/proton.py 1439349
> /proton/trunk/tests/proton_tests/common.py 1439349
>
> Diff: https://reviews.apache.org/r/9123/diff/
>
>
> Testing
> -------
>
> Tested on my Centos 5.9 i686 machine running python 2.4.3.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request: [Proton] changes to support python 2.4
Posted by Philip Harvey <ph...@philharveyonline.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9123/#review15799
-----------------------------------------------------------
The changes look good to me.
However, I have another problem running the tests on my machine using Python 2.4: uuid.py is not found. I think this module was included in Python distributions from v2.5 onwards. Do you intend to address this as part of this Jira?
- Philip Harvey
On Jan. 28, 2013, 5:33 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9123/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 5:33 p.m.)
>
>
> Review request for qpid, Rafael Schloming and Philip Harvey.
>
>
> Description
> -------
>
> Patch to support python 2.4.
>
>
> This addresses bug proton-199.
> https://issues.apache.org/jira/browse/proton-199
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/python/proton.py 1439349
> /proton/trunk/tests/proton_tests/common.py 1439349
>
> Diff: https://reviews.apache.org/r/9123/diff/
>
>
> Testing
> -------
>
> Tested on my Centos 5.9 i686 machine running python 2.4.3.
>
>
> Thanks,
>
> Kenneth Giusti
>
>
Re: Review Request: [Proton] changes to support python 2.4
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9123/#review15757
-----------------------------------------------------------
/proton/trunk/proton-c/bindings/python/proton.py
<https://reviews.apache.org/r/9123/#comment33913>
extraneous whitespace
/proton/trunk/tests/proton_tests/common.py
<https://reviews.apache.org/r/9123/#comment33914>
more extraneous whitespace here
- Rafael Schloming
On Jan. 28, 2013, 5:33 p.m., Kenneth Giusti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9123/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 5:33 p.m.)
>
>
> Review request for qpid, Rafael Schloming and Philip Harvey.
>
>
> Description
> -------
>
> Patch to support python 2.4.
>
>
> This addresses bug proton-199.
> https://issues.apache.org/jira/browse/proton-199
>
>
> Diffs
> -----
>
> /proton/trunk/proton-c/bindings/python/proton.py 1439349
> /proton/trunk/tests/proton_tests/common.py 1439349
>
> Diff: https://reviews.apache.org/r/9123/diff/
>
>
> Testing
> -------
>
> Tested on my Centos 5.9 i686 machine running python 2.4.3.
>
>
> Thanks,
>
> Kenneth Giusti
>
>