You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/25 15:49:04 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #202: Make more the default stack size to DEFAULT_TASK_STACKSIZE

xiaoxiang781216 commented on a change in pull request #202:
URL: https://github.com/apache/incubator-nuttx-apps/pull/202#discussion_r415088331



##########
File path: examples/mount/Kconfig
##########
@@ -35,7 +35,7 @@ if !EXAMPLES_MOUNT_BLOCKDEVICE
 
 config EXAMPLES_MOUNT_NSECTORS
 	int "RAM disk number of sectors"
-	default DEFAULT_TASK_STACKSIZE
+	default 2048

Review comment:
       This is a wrong change by:
   commit e7156be066c7427e2afb56521c3eaf56d7623e25
   Author: YAMAMOTO Takashi <ya...@midokura.com>
   Date:   Fri Mar 27 14:10:33 2020 +0900
   
       Change the defaults of stack size configs to DEFAULT_TASK_STACKSIZE
       
       This commit changes only ones with the default 2048 and
       leaves the others.
       E.g. this leaves SYSTEM_RAMTEST_STACKSIZE, whose default is 1024.
       I guess those need to be inspected one-by-one.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org