[GitHub] [iceberg] rdblue commented on pull request #3714: Types literals all in one primitives pr

[GitBox <gi...@apache.org>]

rdblue commented on pull request #3714:
URL: https://github.com/apache/iceberg/pull/3714#issuecomment-991957594


   @CircArgs, I think that the request to break down these changes wasn't just that there were too many types done in a single PR, it was that too many features were done in a single PR. That's what makes it hard to review. Could you do just one feature in a PR?
   
   For example, I know you'd like to clean up type classes so that you can use `isinstance` the same way for all of them. Could you do that in a single PR? I don't think that we want to add literals and change types in the same PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org