You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/02/16 02:57:56 UTC

[GitHub] dubeejw closed pull request #3292: Remove expected duration from Swift test

dubeejw closed pull request #3292: Remove expected duration from Swift test
URL: https://github.com/apache/incubator-openwhisk/pull/3292
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tests/src/test/scala/whisk/core/cli/test/Swift311Tests.scala b/tests/src/test/scala/whisk/core/cli/test/Swift311Tests.scala
index 1dc19f0cfb..b0b1fee50e 100644
--- a/tests/src/test/scala/whisk/core/cli/test/Swift311Tests.scala
+++ b/tests/src/test/scala/whisk/core/cli/test/Swift311Tests.scala
@@ -35,7 +35,6 @@ class Swift311Tests extends TestHelpers with WskTestHelpers with Matchers {
 
   implicit val wskprops = WskProps()
   val wsk = new WskRest
-  val expectedDuration = 45 seconds
   val activationPollDuration = 60 seconds
   val defaultJsAction = Some(TestUtils.getTestActionFilename("hello.js"))
 
@@ -52,7 +51,6 @@ class Swift311Tests extends TestHelpers with WskTestHelpers with Matchers {
       action.create(name, Some(TestUtils.getTestActionFilename("hello.swift")))
     }
 
-    val start = System.currentTimeMillis()
     withActivation(wsk.activation, wsk.action.invoke(name), totalWait = activationPollDuration) {
       _.response.result.get.toString should include("Hello stranger!")
     }
@@ -63,11 +61,6 @@ class Swift311Tests extends TestHelpers with WskTestHelpers with Matchers {
       totalWait = activationPollDuration) {
       _.response.result.get.toString should include("Hello Sir!")
     }
-
-    withClue("Test duration exceeds expectation (ms)") {
-      val duration = System.currentTimeMillis() - start
-      duration should be <= expectedDuration.toMillis
-    }
   }
 
   behavior of "Swift Whisk SDK tests"


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services