You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by xueyumusic <gi...@git.apache.org> on 2018/12/17 02:53:47 UTC
[GitHub] zeppelin pull request #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0
GitHub user xueyumusic opened a pull request:
https://github.com/apache/zeppelin/pull/3266
[ZEPPELIN-3914] upgrade Flink to 1.7.0
### What is this PR for?
This PR is for upgrading current Flink to 1.7.0
### What type of PR is it?
[Improvement]
### Todos
*no
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3914, [ZEPPELIN-3914](https://issues.apache.org/jira/browse/ZEPPELIN-3914)
### How should this be tested?
*manual
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
no
* Is there breaking changes for older versions?
no
* Does this needs documentation?
no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xueyumusic/zeppelin upgrade-flink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3266
----
commit ad9e739123843e5dcdbbf66e89c719b807dde301
Author: xueyu <27...@...>
Date: 2018-12-16T13:55:46Z
upgrade flink to 1.7.0
----
---
[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0
Posted by liuxunorg <gi...@git.apache.org>.
Github user liuxunorg commented on the issue:
https://github.com/apache/zeppelin/pull/3266
I saw @zjffdu created [[Umbrella] Better support flink interpreter](https://issues.apache.org/jira/browse/ZEPPELIN-3913). It may not be a simple version upgrade, see if @zjffdu has a complete upgrade plan for flink. :-)
---
[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0
Posted by xueyumusic <gi...@git.apache.org>.
Github user xueyumusic commented on the issue:
https://github.com/apache/zeppelin/pull/3266
Hi, @liuxunorg , thanks for your point. I looked at ZEPPELIN-3913 and it mainly aims at streaming engine based on Flink. I think it is better to use new version Flink (currently 1.7) as starting point of streaming engine, and this PR is only for current batch engine and does not introduce extra functions, current tests could cover the modifications. So I think this PR and issue ZEPPELIN-3914 could be a subtask of ZEPPELIN-3913 and does not conflicts with ZEPPELIN-3913.
What do you think ? @zjffdu
---
[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3266
LGTM
---
[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3266
@xueyumusic Thanks for the contribution, we can make it as subtask of ZEPPELIN-3913. BTW I am curious to know whether you are using flink in zeppelin ? If yes, could you share more details ? Because currently I am doing some improvement on flink interpreter and try to provide better user experience for flink users.
---