You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/13 11:14:28 UTC

[GitHub] [airflow] ashb commented on a change in pull request #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator

ashb commented on a change in pull request #7365: [AIRFLOW-5221] add host_aliases to KubernetesPodOperator
URL: https://github.com/apache/airflow/pull/7365#discussion_r378797351
 
 

 ##########
 File path: airflow/kubernetes/pod_generator.py
 ##########
 @@ -116,6 +116,8 @@ class PodGenerator:
     :type affinity: Optional[dict]
     :param hostnetwork: If True enable host networking on the pod
     :type hostnetwork: bool
+    :param host_aliases: A list of hostAliases.
+    :type host_aliases: list hostAliases
 
 Review comment:
   ```suggestion
       :type host_aliases: list
   ```
   
   Plus somewhere (not the type) a link to what structure this should have.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services