[GitHub] [iceberg] singhpk234 commented on a diff in pull request #7665: Core, Parquet: Remove Parquet dictionary encoding table property

["singhpk234 (via GitHub)" <gi...@apache.org>]

singhpk234 commented on code in PR #7665:
URL: https://github.com/apache/iceberg/pull/7665#discussion_r1199540355


##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -246,14 +245,15 @@ public <D> FileAppender<D> build() throws IOException {
       int rowGroupSize = context.rowGroupSize();
       int pageSize = context.pageSize();
       int pageRowLimit = context.pageRowLimit();
-      boolean dictionaryEnabled = context.dictionaryEnabled();
       int dictionaryPageSize = context.dictionaryPageSize();
       String compressionLevel = context.compressionLevel();
       CompressionCodecName codec = context.codec();
       int rowGroupCheckMinRecordCount = context.rowGroupCheckMinRecordCount();
       int rowGroupCheckMaxRecordCount = context.rowGroupCheckMaxRecordCount();
       int bloomFilterMaxBytes = context.bloomFilterMaxBytes();
       Map<String, String> columnBloomFilterEnabled = context.columnBloomFilterEnabled();
+      boolean enableDictionary =
+          Boolean.valueOf(config.getOrDefault(ParquetOutputFormat.ENABLE_DICTIONARY, "true"));

Review Comment:
   [minor] if we going to a new line we can use : 
   ```java
   PropertyUtil.propertyAsBoolean(config, ParquetOutputFormat.ENABLE_DICTIONARY, true);
   ```



##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -246,14 +245,15 @@ public <D> FileAppender<D> build() throws IOException {
       int rowGroupSize = context.rowGroupSize();
       int pageSize = context.pageSize();
       int pageRowLimit = context.pageRowLimit();
-      boolean dictionaryEnabled = context.dictionaryEnabled();

Review Comment:
   can we still keep this in context ? it's private anyways and at times can help in overriding delete and data file seperatly, thoughts ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org