You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/04/17 19:36:10 UTC
[GitHub] [mynewt-nimble] h2zero opened a new pull request #801: Prevent
storing of CCCD's if peer is not bonded.
h2zero opened a new pull request #801: Prevent storing of CCCD's if peer is not bonded.
URL: https://github.com/apache/mynewt-nimble/pull/801
Currently a peer that we have paired with but not bonded will have it's
CCCD status stored. We should not store CCCD data unless bonded,
this will prevent that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #801: Prevent
storing of CCCD's if peer is not bonded.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #801: Prevent storing of CCCD's if peer is not bonded.
URL: https://github.com/apache/mynewt-nimble/pull/801#issuecomment-615457011
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #801:
Prevent storing of CCCD's if peer is not bonded.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on issue #801: Prevent storing of CCCD's if peer is not bonded.
URL: https://github.com/apache/mynewt-nimble/pull/801#issuecomment-615429204
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/src/ble_gatts.c
<details>
```diff
@@ -1679,7 +1679,7 @@
conn = ble_hs_conn_find(conn_handle);
BLE_HS_DBG_ASSERT(conn != NULL);
- if(conn->bhc_sec_state.bonded) {
+ if (conn->bhc_sec_state.bonded) {
cccd_value.peer_addr = conn->bhc_peer_addr;
cccd_value.peer_addr.type =
ble_hs_misc_peer_addr_type_to_id(conn->bhc_peer_addr.type);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #801: Prevent
storing of CCCD's if peer is not bonded.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #801: Prevent storing of CCCD's if peer is not bonded.
URL: https://github.com/apache/mynewt-nimble/pull/801#issuecomment-615429204
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/src/ble_gatts.c
<details>
```diff
@@ -1679,7 +1679,7 @@
conn = ble_hs_conn_find(conn_handle);
BLE_HS_DBG_ASSERT(conn != NULL);
- if(conn->bhc_sec_state.bonded) {
+ if (conn->bhc_sec_state.bonded) {
cccd_value.peer_addr = conn->bhc_peer_addr;
cccd_value.peer_addr.type =
ble_hs_misc_peer_addr_type_to_id(conn->bhc_peer_addr.type);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services