[GitHub] [incubator-pegasus] empiredan commented on a change in pull request #752: feat: support preserving TTL for copy_data

[GitBox <gi...@apache.org>]

empiredan commented on a change in pull request #752:
URL: https://github.com/apache/incubator-pegasus/pull/752#discussion_r651651670



##########
File path: src/idl/rrdb.thrift
##########
@@ -253,6 +253,7 @@ struct get_scanner_request
     9:filter_type  sort_key_filter_type;
     10:dsn.blob    sort_key_filter_pattern;
     11:optional bool    validate_partition_hash;
+    12:optional bool    return_expire_ts;

Review comment:
       Good idea ! expire_ts should be a member of key_value.  Should we use `i32` instead of `bool` for `expire_ts` which is used in `scan_response` to return all of the key-value pairs with optional expire_ts:
   ```
   struct key_value
   {
       1:dsn.blob      key;
       2:dsn.blob      value;
       3:optional i32 expire_ts;
   }
   ```
   where I've used an `expire_ts_seconds_list` to separate the optional `expire_ts` to another list. However, since `return_expire_ts` in get_scanner_request tells the server that the client need expire_ts, should we keep it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org