You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/29 04:43:03 UTC

[GitHub] [spark] xinrong-databricks opened a new pull request #35050: [SPARK-37773][PYTHON] Disable certain doctests of `ps.to_timedelta` for pandas<=1.0.5

xinrong-databricks opened a new pull request #35050:
URL: https://github.com/apache/spark/pull/35050


   ### What changes were proposed in this pull request?
   Disable certain doctests of `ps.to_timedelta` for pandas<=1.0.5
   
   
   ### Why are the changes needed?
   `ps.to_timedelta` is backed by `pd.to_timedelta` (in pandas).
   
   Doctest results of `ps.to_timedelta`  are consistent with the latest pandas.
   
   However, some of them (related to seconds) will fail with pandas <=1.0.5 since older pandas lose precision. So we disable them.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   
   ### How was this patch tested?
   Manual tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #35050: [SPARK-37773][PYTHON] Disable certain doctests of `ps.to_timedelta` for pandas<=1.0.5

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35050:
URL: https://github.com/apache/spark/pull/35050


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35050: [SPARK-37773][PYTHON] Disable certain doctests of `ps.to_timedelta` for pandas<=1.0.5

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35050:
URL: https://github.com/apache/spark/pull/35050#issuecomment-1002400924


   Merged to master.
   
   Since CI doesn't test this, and Python linter passed too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org