[GitHub] [airflow] mik-laj commented on a change in pull request #8888: Add AWS ECS system test

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #8888:
URL: https://github.com/apache/airflow/pull/8888#discussion_r426282931



##########
File path: tests/test_utils/amazon_system_helpers.py
##########
@@ -51,6 +54,27 @@ def provide_aws_s3_bucket(name):
 @pytest.mark.system("amazon")
 class AmazonSystemTest(SystemTest):
 
+    @staticmethod
+    def _region_name():
+        return os.environ.get("REGION_NAME")
+
+    @staticmethod
+    def _registry_id():
+        return os.environ.get("REGISTRY_ID")
+
+    @staticmethod
+    def _repository_name():
+        return os.environ.get("REPOSITORY_NAME")
+
+    @staticmethod
+    def _execution_role_arn():
+        return os.environ.get("EXECUTION_ROLE_ARN")

Review comment:
       Personally, I would like to improve this code a bit, but until it is run on CI, I refrained. We have too many static methods that could be independent methods. This makes it difficult to write tests that apply to many cloud providers. For now, I would prefer to keep consistency in the project, because it will facilitate future refactor.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org