You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Paul Lindner <li...@inuus.com> on 2014/08/25 15:09:37 UTC

Review Request 25024: Update shindig dependencies to latest versions

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25024/
-----------------------------------------------------------

Review request for shindig.


Repository: shindig


Description
-------

Some small code changes required for htmlunit and xercesimpl updates.


Diffs
-----

  trunk/UPGRADING 1618597 
  trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java 1618597 
  trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1618597 
  trunk/pom.xml 1618598 

Diff: https://reviews.apache.org/r/25024/diff/


Testing
-------

All tests pass


Thanks,

Paul Lindner


Re: Review Request 25024: Update shindig dependencies to latest versions

Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25024/#review51405
-----------------------------------------------------------

Ship it!


Ship It!

- Ryan Baxter


On Aug. 25, 2014, 1:09 p.m., Paul Lindner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25024/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 1:09 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Some small code changes required for htmlunit and xercesimpl updates.
> 
> 
> Diffs
> -----
> 
>   trunk/UPGRADING 1618597 
>   trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java 1618597 
>   trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1618597 
>   trunk/pom.xml 1618598 
> 
> Diff: https://reviews.apache.org/r/25024/diff/
> 
> 
> Testing
> -------
> 
> All tests pass
> 
> 
> Thanks,
> 
> Paul Lindner
> 
>


Re: Review Request 25024: Update shindig dependencies to latest versions

Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25024/#review51399
-----------------------------------------------------------

Ship it!


Ship It!

- Stanton Sievers


On Aug. 25, 2014, 1:09 p.m., Paul Lindner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25024/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 1:09 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Some small code changes required for htmlunit and xercesimpl updates.
> 
> 
> Diffs
> -----
> 
>   trunk/UPGRADING 1618597 
>   trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java 1618597 
>   trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1618597 
>   trunk/pom.xml 1618598 
> 
> Diff: https://reviews.apache.org/r/25024/diff/
> 
> 
> Testing
> -------
> 
> All tests pass
> 
> 
> Thanks,
> 
> Paul Lindner
> 
>


Re: Review Request 25024: Update shindig dependencies to latest versions

Posted by Andreas Kohn <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25024/#review51513
-----------------------------------------------------------



trunk/UPGRADING
<https://reviews.apache.org/r/25024/#comment89928>

    Small nitpick: the actual update in the pom is to 18.0, not to 17.0 :)


- Andreas Kohn


On Aug. 25, 2014, 3:09 p.m., Paul Lindner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25024/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 3:09 p.m.)
> 
> 
> Review request for shindig.
> 
> 
> Repository: shindig
> 
> 
> Description
> -------
> 
> Some small code changes required for htmlunit and xercesimpl updates.
> 
> 
> Diffs
> -----
> 
>   trunk/UPGRADING 1618597 
>   trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java 1618597 
>   trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1618597 
>   trunk/pom.xml 1618598 
> 
> Diff: https://reviews.apache.org/r/25024/diff/
> 
> 
> Testing
> -------
> 
> All tests pass
> 
> 
> Thanks,
> 
> Paul Lindner
> 
>