You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "francisdb (JIRA)" <ji...@apache.org> on 2009/02/03 21:09:59 UTC

[jira] Created: (FTPSERVER-272) follow symbolic links

follow symbolic links
---------------------

                 Key: FTPSERVER-272
                 URL: https://issues.apache.org/jira/browse/FTPSERVER-272
             Project: FtpServer
          Issue Type: New Feature
         Environment: unix, linux, mac, ...
            Reporter: francisdb


there should be a way to make the ftpserver follow symbolic links instead of keeping the symbolic link as pwd:

Command:        CWD link
Response:       250 CWD command successful.
Command:        PWD
Response:       257 "/linkedToFolder" is current directory.

you might want to make this the default behavior as some other ftp server do that (to investigate)

for links the file.getAbsolutePath() gives you the link path and file.getCanonicalPath() gives you the real (linked to) path
(only tested on Linux with sun jvm, not sure this is defined in the spec)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FTPSERVER-272) follow symbolic links

Posted by "Francis De Brabandere (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FTPSERVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709281#action_12709281 ] 

Francis De Brabandere commented on FTPSERVER-272:
-------------------------------------------------

if you have a look at other ftp servers you would end up in /home
and if /home is not allowed for this user the cwd.. should just fail, as with any other invalid path.
try the average mirror site, eg ftp.belnet.be, if you cwd to debian-cd you end up somewhere deeper in the filesystem tree and filezilla correctly shows you where you are


no need for path history, maybe that could be implemented on the ftp client side?

> follow symbolic links
> ---------------------
>
>                 Key: FTPSERVER-272
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-272
>             Project: FtpServer
>          Issue Type: New Feature
>         Environment: unix, linux, mac, ...
>            Reporter: Francis De Brabandere
>            Assignee: Niklas Gustavsson
>             Fix For: 1.1
>
>
> there should be a way to make the ftpserver follow symbolic links instead of keeping the symbolic link as pwd:
> Command:        CWD link
> Response:       250 CWD command successful.
> Command:        PWD
> Response:       257 "/linkedToFolder" is current directory.
> you might want to make this the default behavior as some other ftp server do that (to investigate)
> for links the file.getAbsolutePath() gives you the link path and file.getCanonicalPath() gives you the real (linked to) path
> (only tested on Linux with sun jvm, not sure this is defined in the spec)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FTPSERVER-272) follow symbolic links

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FTPSERVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Niklas Gustavsson updated FTPSERVER-272:
----------------------------------------

    Fix Version/s: 1.1
         Assignee: Niklas Gustavsson

> follow symbolic links
> ---------------------
>
>                 Key: FTPSERVER-272
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-272
>             Project: FtpServer
>          Issue Type: New Feature
>         Environment: unix, linux, mac, ...
>            Reporter: francisdb
>            Assignee: Niklas Gustavsson
>             Fix For: 1.1
>
>
> there should be a way to make the ftpserver follow symbolic links instead of keeping the symbolic link as pwd:
> Command:        CWD link
> Response:       250 CWD command successful.
> Command:        PWD
> Response:       257 "/linkedToFolder" is current directory.
> you might want to make this the default behavior as some other ftp server do that (to investigate)
> for links the file.getAbsolutePath() gives you the link path and file.getCanonicalPath() gives you the real (linked to) path
> (only tested on Linux with sun jvm, not sure this is defined in the spec)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FTPSERVER-272) follow symbolic links

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FTPSERVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709130#action_12709130 ] 

Niklas Gustavsson commented on FTPSERVER-272:
---------------------------------------------

How should this work with regards to the user home directory and moving upward (..) with CWD? That is, if user home dir is /home/foo and /home/foo/bar links to /home/bar. Where should the user end up if he does:
CWD bar
CWD ..

Is he now in /home or in /home/foo? I'm assuming /home/foo as otherwise we would allow him access outside of his defined root. If my assumtion is correct, we would need to keep a history of where the user was when he did CWD bar, right?

> follow symbolic links
> ---------------------
>
>                 Key: FTPSERVER-272
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-272
>             Project: FtpServer
>          Issue Type: New Feature
>         Environment: unix, linux, mac, ...
>            Reporter: Francis De Brabandere
>            Assignee: Niklas Gustavsson
>             Fix For: 1.1
>
>
> there should be a way to make the ftpserver follow symbolic links instead of keeping the symbolic link as pwd:
> Command:        CWD link
> Response:       250 CWD command successful.
> Command:        PWD
> Response:       257 "/linkedToFolder" is current directory.
> you might want to make this the default behavior as some other ftp server do that (to investigate)
> for links the file.getAbsolutePath() gives you the link path and file.getCanonicalPath() gives you the real (linked to) path
> (only tested on Linux with sun jvm, not sure this is defined in the spec)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FTPSERVER-272) follow symbolic links

Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FTPSERVER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709287#action_12709287 ] 

Niklas Gustavsson commented on FTPSERVER-272:
---------------------------------------------

Great, that makes this patch very simple. I'll attempt to implement it in 1.1 later today.

> follow symbolic links
> ---------------------
>
>                 Key: FTPSERVER-272
>                 URL: https://issues.apache.org/jira/browse/FTPSERVER-272
>             Project: FtpServer
>          Issue Type: New Feature
>         Environment: unix, linux, mac, ...
>            Reporter: Francis De Brabandere
>            Assignee: Niklas Gustavsson
>             Fix For: 1.1
>
>
> there should be a way to make the ftpserver follow symbolic links instead of keeping the symbolic link as pwd:
> Command:        CWD link
> Response:       250 CWD command successful.
> Command:        PWD
> Response:       257 "/linkedToFolder" is current directory.
> you might want to make this the default behavior as some other ftp server do that (to investigate)
> for links the file.getAbsolutePath() gives you the link path and file.getCanonicalPath() gives you the real (linked to) path
> (only tested on Linux with sun jvm, not sure this is defined in the spec)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.