You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "cbalci (via GitHub)" <gi...@apache.org> on 2024/04/25 22:32:18 UTC
[PR] Add documentation for Apache Pinot integration [datasketches-website]
cbalci opened a new pull request, #173:
URL: https://github.com/apache/datasketches-website/pull/173
Adding documentation to capture the built-in support added to Apache Pinot in the last few years.
I was able to run Jekyll to validate the formatting looks OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] Add documentation for Apache Pinot integration [datasketches-website]
Posted by "cbalci (via GitHub)" <gi...@apache.org>.
cbalci commented on code in PR #173:
URL: https://github.com/apache/datasketches-website/pull/173#discussion_r1581491032
##########
_includes/toc.html:
##########
@@ -248,6 +248,7 @@
<a data-toggle="collapse" class="menu collapsed" href="#collapse_quantiles_studies">Quantiles Studies</a>
</p>
<div class="collapse" id="collapse_quantiles_studies">
+ <li><a href="{{site.docs_dir}}/QuantilesStudies/KllSketchVsTDigest.html">•KLL sketch vs t-digest</a></li>
Review Comment:
Sounds good, removed from 'toc.json' and the html file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] Add documentation for Apache Pinot integration [datasketches-website]
Posted by "cbalci (via GitHub)" <gi...@apache.org>.
cbalci commented on code in PR #173:
URL: https://github.com/apache/datasketches-website/pull/173#discussion_r1580234543
##########
_includes/toc.html:
##########
@@ -248,6 +248,7 @@
<a data-toggle="collapse" class="menu collapsed" href="#collapse_quantiles_studies">Quantiles Studies</a>
</p>
<div class="collapse" id="collapse_quantiles_studies">
+ <li><a href="{{site.docs_dir}}/QuantilesStudies/KllSketchVsTDigest.html">•KLL sketch vs t-digest</a></li>
Review Comment:
It [still exists](https://github.com/apache/datasketches-website/blob/master/src/main/resources/docgen/toc.json#L212) in master branch `toc.json`.
I thought it was inadvertently removed so left in the PR, but please let me know if it was supposed to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] Add documentation for Apache Pinot integration [datasketches-website]
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov commented on code in PR #173:
URL: https://github.com/apache/datasketches-website/pull/173#discussion_r1581460511
##########
_includes/toc.html:
##########
@@ -248,6 +248,7 @@
<a data-toggle="collapse" class="menu collapsed" href="#collapse_quantiles_studies">Quantiles Studies</a>
</p>
<div class="collapse" id="collapse_quantiles_studies">
+ <li><a href="{{site.docs_dir}}/QuantilesStudies/KllSketchVsTDigest.html">•KLL sketch vs t-digest</a></li>
Review Comment:
I seems like we forgot to remove it from json, but it is not visible on the web site, which is intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] Add documentation for Apache Pinot integration [datasketches-website]
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov merged PR #173:
URL: https://github.com/apache/datasketches-website/pull/173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] Add documentation for Apache Pinot integration [datasketches-website]
Posted by "cbalci (via GitHub)" <gi...@apache.org>.
cbalci commented on code in PR #173:
URL: https://github.com/apache/datasketches-website/pull/173#discussion_r1580234543
##########
_includes/toc.html:
##########
@@ -248,6 +248,7 @@
<a data-toggle="collapse" class="menu collapsed" href="#collapse_quantiles_studies">Quantiles Studies</a>
</p>
<div class="collapse" id="collapse_quantiles_studies">
+ <li><a href="{{site.docs_dir}}/QuantilesStudies/KllSketchVsTDigest.html">•KLL sketch vs t-digest</a></li>
Review Comment:
It [still exists](https://github.com/apache/datasketches-website/blob/master/src/main/resources/docgen/toc.json#L212) in master branch `toc.json`.
I thought it was inadvertently removed and left in the PR, but please let me know if it was supposed to be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] Add documentation for Apache Pinot integration [datasketches-website]
Posted by "AlexanderSaydakov (via GitHub)" <gi...@apache.org>.
AlexanderSaydakov commented on code in PR #173:
URL: https://github.com/apache/datasketches-website/pull/173#discussion_r1580227492
##########
_includes/toc.html:
##########
@@ -248,6 +248,7 @@
<a data-toggle="collapse" class="menu collapsed" href="#collapse_quantiles_studies">Quantiles Studies</a>
</p>
<div class="collapse" id="collapse_quantiles_studies">
+ <li><a href="{{site.docs_dir}}/QuantilesStudies/KllSketchVsTDigest.html">•KLL sketch vs t-digest</a></li>
Review Comment:
why this was restored? outdated clone, perhaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org