You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/10 11:48:29 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #27759: [SPARK-31008][SQL]Support json_array_length function

cloud-fan commented on a change in pull request #27759: [SPARK-31008][SQL]Support json_array_length function
URL: https://github.com/apache/spark/pull/27759#discussion_r390259376
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ##########
 @@ -781,3 +782,68 @@ case class SchemaOfJson(
 
   override def prettyName: String = "schema_of_json"
 }
+
+/**
+ * A function that returns the number of elements in outer JSON Array.
+ */
+@ExpressionDescription(
+  usage = "_FUNC_(jsonArray) - Returns the number of elements in outer JSON Array.",
+  arguments = """
+    Arguments:
+      * jsonArray - A JSON array is required as argument. An Exception is thrown if any
+          other valid JSON strings are passed. `NULL` is returned in case of invalid JSON.
 
 Review comment:
   if any other valid JSON strings are passed, we should return null as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org