You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/08 09:35:11 UTC

[GitHub] [shardingsphere] yanyzy opened a new pull request #5471: Use multiple threads to load schemaMetaData

yanyzy opened a new pull request #5471:
URL: https://github.com/apache/shardingsphere/pull/5471


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #5471: Use multiple threads to load schemaMetaData

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5471:
URL: https://github.com/apache/shardingsphere/pull/5471#issuecomment-625758306


   ## Pull Request Test Coverage Report for [Build 11505](https://coveralls.io/builds/30651669)
   
   * **1** of **31**   **(3.23%)**  changed or added relevant lines in **3** files are covered.
   * **50** unchanged lines in **5** files lost coverage.
   * Overall coverage increased (+**0.1%**) to **58.376%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchema.java](https://coveralls.io/builds/30651669/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchema.java#L95) | 0 | 3 | 0.0%
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java](https://coveralls.io/builds/30651669/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fmetadata%2Fschema%2FRuleSchemaMetaDataLoader.java#L86) | 0 | 27 | 0.0%
   <!-- | **Total:** | **1** | **31** | **3.23%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java](https://coveralls.io/builds/30651669/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fmetadata%2Fschema%2FRuleSchemaMetaDataLoader.java#L88) | 1 | 0% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemas.java](https://coveralls.io/builds/30651669/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemas.java#L77) | 6 | 33.33% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java](https://coveralls.io/builds/30651669/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemaFactory.java#L55) | 7 | 0% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/30651669/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L73) | 18 | 6.82% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/30651669/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L70) | 18 | 6.82% |
   <!-- | **Total:** | **50** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30651669/badge)](https://coveralls.io/builds/30651669) |
   | :-- | --: |
   | Change from base [Build 11489](https://coveralls.io/builds/30647447): |  0.1% |
   | Covered Lines: | 12015 |
   | Relevant Lines: | 20582 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on pull request #5471: Use multiple threads to load schemaMetaData

Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #5471:
URL: https://github.com/apache/shardingsphere/pull/5471#issuecomment-625747766


   relate #5167


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #5471: Use multiple threads to load schemaMetaData

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5471:
URL: https://github.com/apache/shardingsphere/pull/5471#issuecomment-625756814


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5471?src=pr&el=h1) Report
   > Merging [#5471](https://codecov.io/gh/apache/shardingsphere/pull/5471?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c522bf186101967328b847e6536b333af8b5863c&el=desc) will **increase** coverage by `0.74%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5471/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5471?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5471      +/-   ##
   ============================================
   + Coverage     54.15%   54.89%   +0.74%     
   - Complexity      421      433      +12     
   ============================================
     Files          1166     1166              
     Lines         20889    20565     -324     
     Branches       3763     3717      -46     
   ============================================
   - Hits          11313    11290      -23     
   + Misses         8860     8565     -295     
   + Partials        716      710       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5471?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...mmon/metadata/schema/RuleSchemaMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL21ldGFkYXRhL3NjaGVtYS9SdWxlU2NoZW1hTWV0YURhdGFMb2FkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...al/datasource/AbstractOrchestrationDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2ludGVybmFsL2RhdGFzb3VyY2UvQWJzdHJhY3RPcmNoZXN0cmF0aW9uRGF0YVNvdXJjZS5qYXZh) | `82.85% <0.00%> (-11.43%)` | `0.00% <0.00%> (ø%)` | |
   | [...ngjdbc/jdbc/adapter/AbstractDataSourceAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2FkYXB0ZXIvQWJzdHJhY3REYXRhU291cmNlQWRhcHRlci5qYXZh) | `89.18% <0.00%> (-5.41%)` | `0.00% <0.00%> (ø%)` | |
   | [...mespace/parser/DataSourceBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmcvc2hhcmRpbmctamRiYy1vcmNoZXN0cmF0aW9uLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0RhdGFTb3VyY2VCZWFuRGVmaW5pdGlvblBhcnNlci5qYXZh) | `90.47% <0.00%> (-0.44%)` | `1.00% <0.00%> (ø%)` | |
   | [...ing/boot/OrchestrationSpringBootConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmcvc2hhcmRpbmctamRiYy1vcmNoZXN0cmF0aW9uLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL3NwcmluZy9ib290L09yY2hlc3RyYXRpb25TcHJpbmdCb290Q29uZmlndXJhdGlvbi5qYXZh) | `88.09% <0.00%> (-0.28%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/shardingproxy/backend/schema/LogicSchemas.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9Mb2dpY1NjaGVtYXMuamF2YQ==) | `33.33% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ardingproxy/backend/schema/LogicSchemaFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9Mb2dpY1NjaGVtYUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...jdbc/jdbc/core/statement/MasterSlaveStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9qZGJjL2NvcmUvc3RhdGVtZW50L01hc3RlclNsYXZlU3RhdGVtZW50LmphdmE=) | | | |
   | [...urce/OrchestrationSpringMasterSlaveDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmcvc2hhcmRpbmctamRiYy1vcmNoZXN0cmF0aW9uLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL3NwcmluZy9kYXRhc291cmNlL09yY2hlc3RyYXRpb25TcHJpbmdNYXN0ZXJTbGF2ZURhdGFTb3VyY2UuamF2YQ==) | | | |
   | [...ngproxy/backend/schema/impl/MasterSlaveSchema.java](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9pbXBsL01hc3RlclNsYXZlU2NoZW1hLmphdmE=) | | | |
   | ... and [21 more](https://codecov.io/gh/apache/shardingsphere/pull/5471/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5471?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5471?src=pr&el=footer). Last update [c522bf1...1b5ed71](https://codecov.io/gh/apache/shardingsphere/pull/5471?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #5471: Use multiple threads to load schemaMetaData

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5471:
URL: https://github.com/apache/shardingsphere/pull/5471#issuecomment-625758306


   ## Pull Request Test Coverage Report for [Build 11496](https://coveralls.io/builds/30649175)
   
   * **0** of **9**   **(0.0%)**  changed or added relevant lines in **1** file are covered.
   * **49** unchanged lines in **4** files lost coverage.
   * Overall coverage increased (+**0.2%**) to **58.425%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java](https://coveralls.io/builds/30649175/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fmetadata%2Fschema%2FRuleSchemaMetaDataLoader.java#L82) | 0 | 9 | 0.0%
   <!-- | **Total:** | **0** | **9** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemas.java](https://coveralls.io/builds/30649175/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemas.java#L77) | 6 | 33.33% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/schema/LogicSchemaFactory.java](https://coveralls.io/builds/30649175/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fschema%2FLogicSchemaFactory.java#L55) | 7 | 0% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/PreparedStatementExecutorWrapper.java](https://coveralls.io/builds/30649175/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FPreparedStatementExecutorWrapper.java#L73) | 18 | 6.82% |
   | [sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/wrapper/StatementExecutorWrapper.java](https://coveralls.io/builds/30649175/source?filename=sharding-proxy%2Fsharding-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fwrapper%2FStatementExecutorWrapper.java#L70) | 18 | 6.82% |
   <!-- | **Total:** | **49** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30649175/badge)](https://coveralls.io/builds/30649175) |
   | :-- | --: |
   | Change from base [Build 11489](https://coveralls.io/builds/30647447): |  0.2% |
   | Covered Lines: | 12015 |
   | Relevant Lines: | 20565 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #5471: Use multiple threads to load schemaMetaData

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5471:
URL: https://github.com/apache/shardingsphere/pull/5471#discussion_r422188395



##########
File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
##########
@@ -142,6 +144,40 @@ public RuleSchemaMetaData load(final DatabaseType databaseType, final DataSource
         return load(databaseType, dataSourceMap, tableName, properties);
     }
     
+    private Map<String, SchemaMetaData> asyncLoad(final DatabaseType databaseType, final Map<String, DataSource> dataSourceMap, final ListeningExecutorService executorService,
+                                                  final int maxConnectionCount, final Collection<String> excludedTableNames) {
+        Map<String, SchemaMetaData> unconfiguredSchemaMetaDataMap = new ConcurrentHashMap<>(dataSourceMap.size(), 1);
+        dataSourceMap.entrySet().stream().map(each -> executorService.submit(() -> {
+            try {
+                SchemaMetaData schemaMetaData = SchemaMetaDataLoader.load(each.getValue(), maxConnectionCount, databaseType.getName(), excludedTableNames);
+                if (!schemaMetaData.getAllTableNames().isEmpty()) {
+                    unconfiguredSchemaMetaDataMap.put(each.getKey(), schemaMetaData);
+                }
+            } catch (SQLException e) {
+                throw new ShardingSphereException("RuleSchemaMetaData load faild", e);
+            }
+        })).forEach(listenableFuture -> {
+            try {
+                listenableFuture.get();
+            } catch (InterruptedException | ExecutionException e) {
+                throw new ShardingSphereException("RuleSchemaMetaData load faild", e);
+            }
+        });
+        return unconfiguredSchemaMetaDataMap;

Review comment:
       It is better to rename return value as `result`

##########
File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
##########
@@ -142,6 +144,40 @@ public RuleSchemaMetaData load(final DatabaseType databaseType, final DataSource
         return load(databaseType, dataSourceMap, tableName, properties);
     }
     
+    private Map<String, SchemaMetaData> asyncLoad(final DatabaseType databaseType, final Map<String, DataSource> dataSourceMap, final ListeningExecutorService executorService,
+                                                  final int maxConnectionCount, final Collection<String> excludedTableNames) {
+        Map<String, SchemaMetaData> unconfiguredSchemaMetaDataMap = new ConcurrentHashMap<>(dataSourceMap.size(), 1);
+        dataSourceMap.entrySet().stream().map(each -> executorService.submit(() -> {
+            try {
+                SchemaMetaData schemaMetaData = SchemaMetaDataLoader.load(each.getValue(), maxConnectionCount, databaseType.getName(), excludedTableNames);
+                if (!schemaMetaData.getAllTableNames().isEmpty()) {
+                    unconfiguredSchemaMetaDataMap.put(each.getKey(), schemaMetaData);
+                }
+            } catch (SQLException e) {
+                throw new ShardingSphereException("RuleSchemaMetaData load faild", e);
+            }
+        })).forEach(listenableFuture -> {
+            try {
+                listenableFuture.get();
+            } catch (InterruptedException | ExecutionException e) {
+                throw new ShardingSphereException("RuleSchemaMetaData load faild", e);
+            }
+        });
+        return unconfiguredSchemaMetaDataMap;
+    }
+    
+    private Map<String, SchemaMetaData> syncLoad(final DatabaseType databaseType, final Map<String, DataSource> dataSourceMap,
+                                                 final int maxConnectionCount, final Collection<String> excludedTableNames) throws SQLException {
+        Map<String, SchemaMetaData> unconfiguredSchemaMetaDataMap = new HashMap<>(dataSourceMap.size(), 1);
+        for (Entry<String, DataSource> entry : dataSourceMap.entrySet()) {
+            SchemaMetaData schemaMetaData = SchemaMetaDataLoader.load(entry.getValue(), maxConnectionCount, databaseType.getName(), excludedTableNames);
+            if (!schemaMetaData.getAllTableNames().isEmpty()) {
+                unconfiguredSchemaMetaDataMap.put(entry.getKey(), schemaMetaData);
+            }
+        }
+        return unconfiguredSchemaMetaDataMap;

Review comment:
       It is better to rename return value as `result`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org