You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/12 02:20:36 UTC

[GitHub] [druid] FrankChen021 commented on pull request #13068: export `com.sun.management.internal` when running Druid under JRE11 and JRE17

FrankChen021 commented on PR #13068:
URL: https://github.com/apache/druid/pull/13068#issuecomment-1243138459

   > * Is this still needed after the changes to JvmMonitor in [Use MXBeans to get GC metrics #12476 #12481](https://github.com/apache/druid/pull/12481)?
   
   Yes, we need it. The `AllocationMetricCollector` differs from the JvmMonitor that we changed before, and I have not found a management API to replace it.
   
   > * Is it `--add-exports` or `--add-opens` that we need?
   
   Basically, `add-opens` can be seen as a super set of `add-exports`. The former one allows us to access non-public methods via reflection while the latter one allows us to access public methods only. Use `add-opens` makes the things simpler.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org