You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/07 10:03:05 UTC

[GitHub] [flink] zhuzhurk opened a new pull request #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

zhuzhurk opened a new pull request #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655
 
 
   ## What is the purpose of the change
   
   This is to resolve the hack in DefaultScheduler. It is a prerequisite of pipelined region scheduling.
   More details see FLINK-14162.
   
   ## Brief change log
   
     - *SchedulerOperations#allocateSlotsAndDeploy now always deploys tasks in a bulk*
     - *LazyFromSourcesSchedulingStrategy now schedules vertices one by one when invoking SchedulerOperations#allocateSlotsAndDeploy(...)*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
    - DefaultSchedulerTest
    - LazyFromSourcesSchedulingStrategyTest (adjusted a bit) 
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610305877
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158973984",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce5175a1aecc627af31edf06d88028591a2e1b50 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158973984) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151) 
   * 737dca31661b75fec6d9152b50e1a6e9986efbaa UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610875453
 
 
   Merging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610305877
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158973984",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce5175a1aecc627af31edf06d88028591a2e1b50 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158973984) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610875349
 
 
   The test failures are caused by another PR (FLINK-17040). Ignore it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610305877
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158973984",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159240533",
       "triggerID" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7190",
       "triggerID" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159240533",
       "triggerID" : "610822029",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 737dca31661b75fec6d9152b50e1a6e9986efbaa Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159240533) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7190) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610305877
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158973984",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce5175a1aecc627af31edf06d88028591a2e1b50 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/158973984) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610822029
 
 
   @flinkbot run travis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610298317
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit ce5175a1aecc627af31edf06d88028591a2e1b50 (Tue Apr 07 10:07:28 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk merged pull request #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zhuzhurk commented on a change in pull request #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#discussion_r405281268
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/LazyFromSourcesSchedulingStrategyTest.java
 ##########
 @@ -351,9 +354,13 @@ private LazyFromSourcesSchedulingStrategy startScheduling(TestingSchedulingTopol
 	}
 
 	private void assertLatestScheduledVerticesAreEqualTo(final List<TestingSchedulingExecutionVertex> expected) {
-		assertEquals(
-			idsFromVertices(expected),
-			idsFromDeploymentOptions(testingSchedulerOperation.getLatestScheduledVertices()));
+		final List<List<ExecutionVertexDeploymentOption>> deploymentOptions = testingSchedulerOperation.getScheduledVertices();
+		assertThat(expected.size(), Matchers.lessThanOrEqualTo(deploymentOptions.size()));
 
 Review comment:
   OK. I will do it along with rebasing this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610305877
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158973984",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159240533",
       "triggerID" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7190",
       "triggerID" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159240533",
       "triggerID" : "610822029",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 737dca31661b75fec6d9152b50e1a6e9986efbaa Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159240533) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7190) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610305877
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158973984",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/159240533",
       "triggerID" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "triggerType" : "PUSH"
     }, {
       "hash" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7190",
       "triggerID" : "737dca31661b75fec6d9152b50e1a6e9986efbaa",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce5175a1aecc627af31edf06d88028591a2e1b50 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158973984) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151) 
   * 737dca31661b75fec6d9152b50e1a6e9986efbaa Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159240533) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7190) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610305877
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce5175a1aecc627af31edf06d88028591a2e1b50 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] GJL commented on a change in pull request #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#discussion_r405278158
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/strategy/LazyFromSourcesSchedulingStrategyTest.java
 ##########
 @@ -351,9 +354,13 @@ private LazyFromSourcesSchedulingStrategy startScheduling(TestingSchedulingTopol
 	}
 
 	private void assertLatestScheduledVerticesAreEqualTo(final List<TestingSchedulingExecutionVertex> expected) {
-		assertEquals(
-			idsFromVertices(expected),
-			idsFromDeploymentOptions(testingSchedulerOperation.getLatestScheduledVertices()));
+		final List<List<ExecutionVertexDeploymentOption>> deploymentOptions = testingSchedulerOperation.getScheduledVertices();
+		assertThat(expected.size(), Matchers.lessThanOrEqualTo(deploymentOptions.size()));
 
 Review comment:
   We normally add the static import when using matchers.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11655: [FLINK-14162][runtime] SchedulerOperations#allocateSlotsAndDeploy always deploys tasks in a bulk
URL: https://github.com/apache/flink/pull/11655#issuecomment-610305877
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     }, {
       "hash" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/158973984",
       "triggerID" : "ce5175a1aecc627af31edf06d88028591a2e1b50",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * ce5175a1aecc627af31edf06d88028591a2e1b50 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/158973984) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7151) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services