[jira] [Closed] (THRIFT-1323) TFramedTransport should throw an exception that distinguishes an oversized frame from a dead client, servers should log that exception

["James E. King III (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James E. King III closed THRIFT-1323.
-------------------------------------
       Resolution: Duplicate
         Assignee: James E. King III
    Fix Version/s: 0.10.0

> TFramedTransport should throw an exception that distinguishes an oversized frame from a dead client, servers should log that exception
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1323
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1323
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>            Reporter: Jim Ancona
>            Assignee: James E. King III
>            Priority: Major
>             Fix For: 0.10.0
>
>
> When TFramedTransport receives a frame that is larger than the maximum frame size, it throws a TTransportException. This makes that error indistinguishable from a failed client. Because such errors are common, many servers (TSimpleServer, TThreadPoolServer, and Cassandra's CustomTThreadPoolServer) swallow TTransportException without a log message, making it difficult to diagnose this problem. I'm not familiar enough with the code base to suggest which exception to throw in its place, although a subclass of TTransportException, or a new TTransportException.type_ value might work. In any case, the corresponding server implementations should log that condition when it occurs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)