[GitHub] paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support

[GitBox <gi...@apache.org>]

paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support
URL: https://github.com/apache/drill/pull/1244#issuecomment-409801351
 
 
   @vrozov, thanks for the explanation. This is exactly what we've discussed multiple times over the last several months. In fact, I offered a fix for that problem, but it seemed that @ilooner disagreed with the approach and I don't have time to pursue it further. Hopefully your `MaterializedField` refactoring will fix it.
   
   The whole reason this PR has been stalled is due to a bug that showed up only in the pre-commit tests when @Ben-Zvi tried to commit it. I've been stuck ever since.
   
   I'm pretty much at a dead end on this PR. If the bug is pre-existing and only occurs in the private MapR pre-commit tests, then there is not much I can do to fix it.
   
   This PR has been revised to provide a workaround for the only vector change that this PR introduced. It would be very useful to please re-run the pre-commit tests to see if the workaround corrected the issue that showed up only with this PR in the pre-commit tests.
   
   The other, pre-existing issue would be great to fix, just not in this PR. As I've noted, I'm getting rusty on the code and have other commitments, and so it would be hard for me to fix bugs unrelated to this work. 
   
   Is there a reason to hold up another trial run of this PR while waiting for a fix for the map problem?
   
   As this is stalled, others are slowly recreating the work already completed here. Seems a terrible waste of resources for a small team that has quite a bit of work ahead of it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services