You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/28 13:33:28 UTC
[GitHub] [arrow-datafusion-python] martin-g opened a new pull request, #85: Upgrade Maturin to 0.14.2
martin-g opened a new pull request, #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85
0.13.1 hangs on Linux ARM64
Command used to re-generate the hashes:
`pip-compile --generate-hashes --upgrade-package maturin requirements.in`
# Which issue does this PR close?
Closes #84 .
# Rationale for this change
There is no problem is latest version of `maturin` (0.14.2)
# What changes are included in this PR?
Updates maturin from 0.13.1 to 0.14.2
# Are there any user-facing changes?
Build dependency is updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] martin-g commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329695580
I can't reproduce it here due to:
```
$ docker pull ghcr.io/pyo3/maturin:v0.14.2
Error response from daemon: Head "https://ghcr.io/v2/pyo3/maturin/manifests/v0.14.2": denied: denied
```
weird...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329791596
> Do you really need to support manylinux2010 ?
I'm very new to Python packaging, so not really qualified to answer this.
Maybe @isidentical has thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329792361
Do we just need to use a newer version of manylinux?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] martin-g commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329785422
@andygrove
With v0.13.1 `maturin build --help` says: `Note that `manylinux1` is unsupported by the rust compiler.`
With v0.14.2 it now says: `Note that `manylinux1` and `manylinux2010` is unsupported by the rust compiler.`
Do you really need to support manylinux2010 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] martin-g commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329792846
I've just re-tested with maturin 0.13.7 (last from 0.13.x) and it hangs on Linux ARM64.
0.14.0 works on Linux ARM64 but does not support `manylinux2010`.
@andygrove If you need to support `manylinux2010` then feel free to revert my commit (or I can send a new PR). Otherwise I can send a new PR to build for `manylinux2012` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] martin-g commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1330165130
Good!
I will send a PR shortly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329360014
@martin-g After merging his, I see it has caused a failure in building the Python wheels.
https://github.com/apache/arrow-datafusion-python/actions/runs/3566140311/jobs/5992260113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] martin-g commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329427276
I'll take a look later!
On Mon, Nov 28, 2022, 18:10 Andy Grove ***@***.***> wrote:
> @martin-g <https://github.com/martin-g> After merging this, I see it has
> caused a failure in building the Python wheels.
>
>
> https://github.com/apache/arrow-datafusion-python/actions/runs/3566140311/jobs/5992260113
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329360014>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AABYUQULVGXSB4N6SRL7SA3WKTKQTANCNFSM6AAAAAASNK3X6A>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove merged pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] martin-g commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329764044
I can pull the image on another machine!
I'm debugging it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] isidentical commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
isidentical commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329800652
> Do you really need to support manylinux2010 ?
The only [active Python releases](url) that can't handle `manylinux2014` is the ones between `>=3.7.0,<3.7.9` (so only older bugfix releases of `3.7`), and looking at the [download stats from PyPI package](https://pypistats.org/packages/datafusion) 3.7 as a whole (which we would be still supporting, but only 3.7.8+ for wheels) represents only a very small percentage of the downloads across all versions. So I think it is safe to move with 2014.
> P.S: I also wanted checked polars to see what they are doing, and it seems like they are also publishing wheels for `manylinux2014`. I'd say let's go for it (and let's also add arm wheels)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion-python] andygrove commented on pull request #85: Upgrade Maturin to 0.14.2
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #85:
URL: https://github.com/apache/arrow-datafusion-python/pull/85#issuecomment-1329822524
Thanks @martin-g and @isidentical. Moving to manylinux2014 sounds good to me. I noticed that Ballista is already using this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org