You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "cpoerschke (via GitHub)" <gi...@apache.org> on 2024/07/24 14:36:04 UTC
[PR] SOLR-17298: multi-threaded search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when need(TopDocs|MaxScore|DocSet) is false [solr]
cpoerschke opened a new pull request, #2588:
URL: https://github.com/apache/solr/pull/2588
https://issues.apache.org/jira/browse/SOLR-17298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when need(TopDocs|MaxScore|DocSet) is false [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke closed pull request #2588: SOLR-13350, SOLR-17298: multi-threaded search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when need(TopDocs|MaxScore|DocSet) is false
URL: https://github.com/apache/solr/pull/2588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when need(TopDocs|MaxScore|DocSet) is false [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #2588:
URL: https://github.com/apache/solr/pull/2588#discussion_r1705495049
##########
solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java:
##########
@@ -116,7 +116,7 @@ SearchResult searchCollectorManagers(
ScoreMode scoreMode = SolrMultiCollectorManager.scoreMode(firstCollectors);
- return new SearchResult(scoreMode, ret);
+ return new SearchResult(scoreMode, ret, needTopDocs, needMaxScore, needDocSet);
Review Comment:
granted a trio of booleans is hard to interpret at the call-sight in Java but at least an IDE nowadays shows the names. This problem already started at `MulitThreadedSeacher.searchCollectorManagers()` (where this is more of a concern as it's called by SolrIndexSearcher) so here you just follow-suit, I understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17298: multi-threaded search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when need(TopDocs|MaxScore|DocSet) is false [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on PR #2588:
URL: https://github.com/apache/solr/pull/2588#issuecomment-2248248868
https://github.com/apache/solr/actions/runs/10078717202/job/27864279172 failure seems unrelated.
```
ERROR: The following test(s) have failed:
- org.apache.solr.cloud.SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull (:solr:core)
Test history: https://ge.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.cloud.SplitShardWithNodeRoleTest&tests.test=testSolrClusterWithNodeRoleWithPull http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.cloud.SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull
Test output: /tmp/src/solr/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.cloud.SplitShardWithNodeRoleTest.txt
Reproduce with: ./gradlew :solr:core:test --tests "org.apache.solr.cloud.SplitShardWithNodeRoleTest.testSolrClusterWithNodeRoleWithPull" -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=89EA9C63FAA669C2 -Ptests.timeoutSuite=600000! -Ptests.file.encoding=UTF-8
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when need(TopDocs|MaxScore|DocSet) is false [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on PR #2588:
URL: https://github.com/apache/solr/pull/2588#issuecomment-2277879973
closing since thought to be no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org