You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/20 21:28:08 UTC
[GitHub] [hudi] alexeykudinkin opened a new pull request, #5377: [WIP] Fixing `Spark32HoodieParquetFileFormat` not being compatible w/ Spark 3.2.0
alexeykudinkin opened a new pull request, #5377:
URL: https://github.com/apache/hudi/pull/5377
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #5377: [HUDI-3935] Adding config to fallback to enabled Partition Values extraction from Partition path
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #5377:
URL: https://github.com/apache/hudi/pull/5377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [HUDI-3935] Adding config to fallback to appending columns
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104683924
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
}, {
"hash" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181",
"triggerID" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"triggerType" : "PUSH"
}, {
"hash" : "51333eb5d762d8c8c609db0170870abeef080e91",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8186",
"triggerID" : "51333eb5d762d8c8c609db0170870abeef080e91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e63b627a05cb930c832e94a8e5e0dddce393a291 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181)
* 51333eb5d762d8c8c609db0170870abeef080e91 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8186)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [WIP] Adding config to fallback to appending columns
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104475283
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #5377: [HUDI-3935] Adding config to fallback to appending columns
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #5377:
URL: https://github.com/apache/hudi/pull/5377#discussion_r854755407
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -820,8 +818,8 @@ public PropertyBuilder setPartitionMetafileUseBaseFormat(Boolean useBaseFormat)
return this;
}
- public PropertyBuilder setDropPartitionColumnsWhenWrite(Boolean dropPartitionColumnsWhenWrite) {
Review Comment:
having "write" in the name makes is clear. If not, one could read it as "should drop partition columns when reading". So, I feel we can leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [WIP] Adding config to fallback to appending columns
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104561075
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
}, {
"hash" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181",
"triggerID" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e63b627a05cb930c832e94a8e5e0dddce393a291 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [WIP] Adding config to fallback to appending columns
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104477427
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
}, {
"hash" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179)
* e63b627a05cb930c832e94a8e5e0dddce393a291 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #5377: [HUDI-3935] Adding config to fallback to enabled Partition Values extraction from Partition path
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #5377:
URL: https://github.com/apache/hudi/pull/5377#discussion_r854918528
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -774,4 +785,23 @@ object DataSourceOptionsHelper {
override def apply (input: From): To = function (input)
}
}
+
+ implicit def convert[T, U](prop: ConfigProperty[T])(implicit converter: T => U): ConfigProperty[U] = {
+ checkState(prop.hasDefaultValue)
Review Comment:
this could implicitly break when add a new config with no default. i see this improves code quality but we should avoid nice-to-have changes in the last min patch before release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] TengHuo commented on pull request #5377: [HUDI-3935] Adding config to fallback to enabled Partition Values extraction from Partition path
Posted by GitBox <gi...@apache.org>.
TengHuo commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1314686649
Hi @alexeykudinkin
As I understand, when this config `hoodie.datasource.read.extract.partition.values.from.path` is `false`, it preserves the same behaviour as previous version (version < 0.11.0). Am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [HUDI-3935] Adding config to fallback to enabled Partition Values extraction from Partition path
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104724971
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
}, {
"hash" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181",
"triggerID" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"triggerType" : "PUSH"
}, {
"hash" : "51333eb5d762d8c8c609db0170870abeef080e91",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8186",
"triggerID" : "51333eb5d762d8c8c609db0170870abeef080e91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 51333eb5d762d8c8c609db0170870abeef080e91 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8186)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [HUDI-3935] Adding config to fallback to appending columns
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104682484
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
}, {
"hash" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181",
"triggerID" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"triggerType" : "PUSH"
}, {
"hash" : "51333eb5d762d8c8c609db0170870abeef080e91",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "51333eb5d762d8c8c609db0170870abeef080e91",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e63b627a05cb930c832e94a8e5e0dddce393a291 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181)
* 51333eb5d762d8c8c609db0170870abeef080e91 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [WIP] Adding config to fallback to appending columns
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104481651
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
}, {
"hash" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179)
* e63b627a05cb930c832e94a8e5e0dddce393a291 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on pull request #5377: [HUDI-3935] Adding config to fallback to enabled Partition Values extraction from Partition path
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1315766199
@TengHuo correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] TengHuo commented on pull request #5377: [HUDI-3935] Adding config to fallback to enabled Partition Values extraction from Partition path
Posted by GitBox <gi...@apache.org>.
TengHuo commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1316213272
Got it, thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [WIP] Fixing `Spark32HoodieParquetFileFormat` not being compatible w/ Spark 3.2.0
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104473130
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5377: [WIP] Adding config to fallback to appending columns
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5377:
URL: https://github.com/apache/hudi/pull/5377#issuecomment-1104523033
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179",
"triggerID" : "08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af",
"triggerType" : "PUSH"
}, {
"hash" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181",
"triggerID" : "e63b627a05cb930c832e94a8e5e0dddce393a291",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 08b5e4ffe19d6b2bcf99d97edc6ae825b2eca0af Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8179)
* e63b627a05cb930c832e94a8e5e0dddce393a291 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8181)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5377: [HUDI-3935] Adding config to fallback to enabled Partition Values extraction from Partition path
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #5377:
URL: https://github.com/apache/hudi/pull/5377#discussion_r855420115
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:
##########
@@ -774,4 +785,23 @@ object DataSourceOptionsHelper {
override def apply (input: From): To = function (input)
}
}
+
+ implicit def convert[T, U](prop: ConfigProperty[T])(implicit converter: T => U): ConfigProperty[U] = {
+ checkState(prop.hasDefaultValue)
Review Comment:
If this will break it will break when the class is loaded, meaning that all the tests using class would be broken, which is very easy to diagnose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org