[GitHub] [solr] dsmiley commented on pull request #894: SOLR-16236: Clarify use of GSON jar in jaegertracer-configurator

[GitBox <gi...@apache.org>]

dsmiley commented on PR #894:
URL: https://github.com/apache/solr/pull/894#issuecomment-1147851975

   Check out the documentation of the sampler choices: https://www.jaegertracing.io/docs/1.22/sampling/
   The `remote` choice is rather exotic IMO; I acknowledge it is nonetheless the default.  We can more clearly document changing it, thus encouraging people to do so.
   Nonetheless I don't feel too strongly about this.  My preference is to reduce needless dependency exposure.  But I see we already include it in some other modules (Tika, GCS, ...)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org