You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (JIRA)" <ji...@apache.org> on 2016/05/16 14:28:12 UTC

[jira] [Comment Edited] (MNG-5567) Zip files are not included in classpaths at all

    [ https://issues.apache.org/jira/browse/MNG-5567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15284643#comment-15284643 ] 

Michael Osipov edited comment on MNG-5567 at 5/16/16 2:27 PM:
--------------------------------------------------------------

Yes, I am and I already have a working version on my machine.

You can apply this patch against master and try yourself:

{noformat}
index 2f26ce2..92ddaec 100644
--- a/maven-core/src/main/resources/META-INF/plexus/artifact-handlers.xml
+++ b/maven-core/src/main/resources/META-INF/plexus/artifact-handlers.xml
@@ -190,5 +190,18 @@ Artifact handlers are required by the dependency resolution mechanism.
       </configuration>
     </component>

+    <!--
+     | ZIP
+     |-->
+    <component>
+      <role>org.apache.maven.artifact.handler.ArtifactHandler</role>
+      <role-hint>zip</role-hint>
+      <implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
+      <configuration>
+        <type>zip</type>
+        <addedToClasspath>true</addedToClasspath>
+      </configuration>
+    </component>
+
   </components>
 </component-set>
diff --git a/maven-core/src/site/apt/artifact-handlers.apt b/maven-core/src/site/apt/artifact-handlers.apt
index 1a4b344..79572ad 100644
--- a/maven-core/src/site/apt/artifact-handlers.apt
+++ b/maven-core/src/site/apt/artifact-handlers.apt
@@ -53,3 +53,5 @@ Default Artifact Handlers Reference
 *--------------------+------------+------------+---------------+-----------+---------------------+-----------------------+
 | <<<test-jar>>>     | <<<jar>>>  | <<<jar>>>  | <<<tests>>>   | java      | <<<true>>>          |                       |
 *--------------------+------------+------------+---------------+-----------+---------------------+-----------------------+
+| <<<zip>>>          | <= type>   | <= type>   |               | none      | <<<true>>>          |                       |
+*--------------------+------------+------------+---------------+-----------+---------------------+-----------------------+
\ No newline at end of file
{noformat}


was (Author: michael-o):
Yes, I am and I already have a working version on my machine.

You can apply this patch against master and try yourself:

{code:patch}
index 2f26ce2..92ddaec 100644
--- a/maven-core/src/main/resources/META-INF/plexus/artifact-handlers.xml
+++ b/maven-core/src/main/resources/META-INF/plexus/artifact-handlers.xml
@@ -190,5 +190,18 @@ Artifact handlers are required by the dependency resolution mechanism.
       </configuration>
     </component>

+    <!--
+     | ZIP
+     |-->
+    <component>
+      <role>org.apache.maven.artifact.handler.ArtifactHandler</role>
+      <role-hint>zip</role-hint>
+      <implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
+      <configuration>
+        <type>zip</type>
+        <addedToClasspath>true</addedToClasspath>
+      </configuration>
+    </component>
+
   </components>
 </component-set>
diff --git a/maven-core/src/site/apt/artifact-handlers.apt b/maven-core/src/site/apt/artifact-handlers.apt
index 1a4b344..79572ad 100644
--- a/maven-core/src/site/apt/artifact-handlers.apt
+++ b/maven-core/src/site/apt/artifact-handlers.apt
@@ -53,3 +53,5 @@ Default Artifact Handlers Reference
 *--------------------+------------+------------+---------------+-----------+---------------------+-----------------------+
 | <<<test-jar>>>     | <<<jar>>>  | <<<jar>>>  | <<<tests>>>   | java      | <<<true>>>          |                       |
 *--------------------+------------+------------+---------------+-----------+---------------------+-----------------------+
+| <<<zip>>>          | <= type>   | <= type>   |               | none      | <<<true>>>          |                       |
+*--------------------+------------+------------+---------------+-----------+---------------------+-----------------------+
\ No newline at end of file
{code}

> Zip files are not included in classpaths at all
> -----------------------------------------------
>
>                 Key: MNG-5567
>                 URL: https://issues.apache.org/jira/browse/MNG-5567
>             Project: Maven
>          Issue Type: Bug
>          Components: Dependencies
>    Affects Versions: 3.3.9
>            Reporter: Pablo La Greca
>            Assignee: Michael Osipov
>            Priority: Critical
>             Fix For: 3.4.0
>
>
> when i added a dependency that was zip file 
> eg
> {code:xml} 		<dependency>
> 			<groupId>hsqldb</groupId>
> 			<artifactId>hsqldb</artifactId>
> 			<version>1.7.3.0</version>
> 			<scope>provided</scope>
> 			<type>zip</type>
> 		</dependency>
> {code}
>  this file was not included in the test classpath and so the test would not pass



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)