You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "John Patterson (JIRA)" <ji...@apache.org> on 2008/03/07 21:01:48 UTC
[jira] Created: (WICKET-1402) External JAvascript references not
included
External JAvascript references not included
-------------------------------------------
Key: WICKET-1402
URL: https://issues.apache.org/jira/browse/WICKET-1402
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.1
Reporter: John Patterson
Priority: Critical
When using IHeaderResponse to include an external Javascript file, it is not included because of this bug:
Index: /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
===================================================================
--- /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java (revision 614519)
+++ /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java (working copy)
@@ -177,7 +177,7 @@
{
List token1 = Arrays.asList(new Object[] { "javascript", url });
List token2 = Arrays.asList(new Object[] { "javascript", id });
- if (wasRendered(token1) == false && wasRendered(token2))
+ if (wasRendered(token1) == false && wasRendered(token2) == false)
{
JavascriptUtils.writeJavascriptUrl(getResponse(), url, id);
markRendered(token1);
@@ -258,8 +258,7 @@
{
if (!closed)
{
- List token = Arrays
- .asList(new Object[] { "javascript-event", target, event, javascript });
+ List token = Arrays.asList(new Object[] { "javascript-event", target, event, javascript });
if (wasRendered(token) == false)
{
renderJavascriptReference(WicketEventReference.INSTANCE);
@@ -264,7 +263,7 @@
{
renderJavascriptReference(WicketEventReference.INSTANCE);
JavascriptUtils.writeJavascript(getResponse(), "Wicket.Event.add(" + target +
- ", \"" + event + "\", function() { " + javascript + ";});");
+ ", \"" + event + "\", function() { " + javascript + ";});");
markRendered(token);
}
}
@@ -275,7 +274,7 @@
*/
public void close()
{
- this.closed = true;
+ closed = true;
}
/**
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1402) External JAvascript references not
included
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1402.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.3.2
Assignee: Igor Vaynberg
> External JAvascript references not included
> -------------------------------------------
>
> Key: WICKET-1402
> URL: https://issues.apache.org/jira/browse/WICKET-1402
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: John Patterson
> Assignee: Igor Vaynberg
> Priority: Critical
> Fix For: 1.3.2
>
>
> When using IHeaderResponse to include an external Javascript file, it is not included because of this bug:
> Index: /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java (revision 614519)
> +++ /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java (working copy)
> @@ -177,7 +177,7 @@
> {
> List token1 = Arrays.asList(new Object[] { "javascript", url });
> List token2 = Arrays.asList(new Object[] { "javascript", id });
> - if (wasRendered(token1) == false && wasRendered(token2))
> + if (wasRendered(token1) == false && wasRendered(token2) == false)
> {
> JavascriptUtils.writeJavascriptUrl(getResponse(), url, id);
> markRendered(token1);
> @@ -258,8 +258,7 @@
> {
> if (!closed)
> {
> - List token = Arrays
> - .asList(new Object[] { "javascript-event", target, event, javascript });
> + List token = Arrays.asList(new Object[] { "javascript-event", target, event, javascript });
> if (wasRendered(token) == false)
> {
> renderJavascriptReference(WicketEventReference.INSTANCE);
> @@ -264,7 +263,7 @@
> {
> renderJavascriptReference(WicketEventReference.INSTANCE);
> JavascriptUtils.writeJavascript(getResponse(), "Wicket.Event.add(" + target +
> - ", \"" + event + "\", function() { " + javascript + ";});");
> + ", \"" + event + "\", function() { " + javascript + ";});");
> markRendered(token);
> }
> }
> @@ -275,7 +274,7 @@
> */
> public void close()
> {
> - this.closed = true;
> + closed = true;
> }
>
> /**
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1402) External JAvascript references not
included
Posted by "John Patterson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576355#action_12576355 ]
John Patterson commented on WICKET-1402:
----------------------------------------
Sorry that patch is rubbish - I don;t know why that other stuff was included. Here we go...
Index: /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
===================================================================
--- /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java (revision 614519)
+++ /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java (working copy)
@@ -177,7 +177,7 @@
{
List token1 = Arrays.asList(new Object[] { "javascript", url });
List token2 = Arrays.asList(new Object[] { "javascript", id });
- if (wasRendered(token1) == false && wasRendered(token2))
+ if (wasRendered(token1) == false && wasRendered(token2) == false)
{
JavascriptUtils.writeJavascriptUrl(getResponse(), url, id);
markRendered(token1);
> External JAvascript references not included
> -------------------------------------------
>
> Key: WICKET-1402
> URL: https://issues.apache.org/jira/browse/WICKET-1402
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: John Patterson
> Priority: Critical
>
> When using IHeaderResponse to include an external Javascript file, it is not included because of this bug:
> Index: /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java
> ===================================================================
> --- /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java (revision 614519)
> +++ /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/html/internal/HeaderResponse.java (working copy)
> @@ -177,7 +177,7 @@
> {
> List token1 = Arrays.asList(new Object[] { "javascript", url });
> List token2 = Arrays.asList(new Object[] { "javascript", id });
> - if (wasRendered(token1) == false && wasRendered(token2))
> + if (wasRendered(token1) == false && wasRendered(token2) == false)
> {
> JavascriptUtils.writeJavascriptUrl(getResponse(), url, id);
> markRendered(token1);
> @@ -258,8 +258,7 @@
> {
> if (!closed)
> {
> - List token = Arrays
> - .asList(new Object[] { "javascript-event", target, event, javascript });
> + List token = Arrays.asList(new Object[] { "javascript-event", target, event, javascript });
> if (wasRendered(token) == false)
> {
> renderJavascriptReference(WicketEventReference.INSTANCE);
> @@ -264,7 +263,7 @@
> {
> renderJavascriptReference(WicketEventReference.INSTANCE);
> JavascriptUtils.writeJavascript(getResponse(), "Wicket.Event.add(" + target +
> - ", \"" + event + "\", function() { " + javascript + ";});");
> + ", \"" + event + "\", function() { " + javascript + ";});");
> markRendered(token);
> }
> }
> @@ -275,7 +274,7 @@
> */
> public void close()
> {
> - this.closed = true;
> + closed = true;
> }
>
> /**
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.