[GitHub] benlamonica commented on a change in pull request #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records.

[GitBox <gi...@apache.org>]

benlamonica commented on a change in pull request #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records.
URL: https://github.com/apache/flink/pull/6610#discussion_r212623923
 
 

 ##########
 File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/streamrecord/LatencyMarker.java
 ##########
 @@ -67,31 +67,40 @@ public int getSubtaskIndex() {
 	// ------------------------------------------------------------------------
 
 	@Override
-	public boolean equals(Object o) {
-		if (this == o) {
+	public boolean equals(Object obj) {
 
 Review comment:
   Yes, the prior implementation did this:
   `if (operatorId != that.operatorId) {`
   instead of calling equals(), which resulted in a false if the object is equivalent, but not the exact same object (for example, when the bytestream is copied).
   
   These changes are just from eclipse generating the equals and hashCode methods. I needed to do this so that the unit test would actually pass since it uses the equals method in it's assertion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services