You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Vladislav Pyatkov (Jira)" <ji...@apache.org> on 2022/12/07 15:07:00 UTC
[jira] [Updated] (IGNITE-18351) Make a lock menagment interface modre friendly

     [ https://issues.apache.org/jira/browse/IGNITE-18351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladislav Pyatkov updated IGNITE-18351:
---------------------------------------
    Description: 
Recently, we redesigned the behavior of lock manager, but did not modify the interface. This leads the method name does not compatible that the method do.
The ticket inspires to improve interface of lock manager to avoid using the interface wrong.
* The lock mode LockMode#NL is used nowhere. It is s candidate to remove.
* The LockManager#release(org.apache.ignite.internal.tx.Lock) method is removed all locks on a particular transaction, but the method takes a lock (not a transaction id). Redesign the method in order to release all lock for the particular transaction.
* The LockManager#release(UUID, LockKey, LockMode) releases a particular lock, but the method does not take a lock object.

  was:
Recently, we redesigned the behavior of lock manager, but did not modify the interface. This leads the method name does not compatible that the method do.
The ticket inspires to improve interface of lock manager to avoid using the interface wrong.
1) The lock mode LockMode#NL is used nowhere. It is s candidate to remove.
2) The LockManager#release(org.apache.ignite.internal.tx.Lock) method is removed all locks on a particular transaction, but the method takes a lock (not a transaction id). Redesign the method in order to release all lock for the particular transaction.
3) The LockManager#release(UUID, LockKey, LockMode) releases a particular lock, but the method does not take a lock object.


> Make a lock menagment interface modre friendly
> ----------------------------------------------
>
>                 Key: IGNITE-18351
>                 URL: https://issues.apache.org/jira/browse/IGNITE-18351
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Vladislav Pyatkov
>            Priority: Major
>              Labels: ignite-3
>
> Recently, we redesigned the behavior of lock manager, but did not modify the interface. This leads the method name does not compatible that the method do.
> The ticket inspires to improve interface of lock manager to avoid using the interface wrong.
> * The lock mode LockMode#NL is used nowhere. It is s candidate to remove.
> * The LockManager#release(org.apache.ignite.internal.tx.Lock) method is removed all locks on a particular transaction, but the method takes a lock (not a transaction id). Redesign the method in order to release all lock for the particular transaction.
> * The LockManager#release(UUID, LockKey, LockMode) releases a particular lock, but the method does not take a lock object.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)