[GitHub] [hadoop] szilard-nemeth commented on a diff in pull request #4960: YARN-6766 HelperMethod added in AppsBlock class

[GitBox <gi...@apache.org>]

szilard-nemeth commented on code in PR #4960:
URL: https://github.com/apache/hadoop/pull/4960#discussion_r990101123


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##########
@@ -129,6 +129,12 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest hsr) {
     return true;
   }
 
+  private static String printAppInfo(long appInfoFunc) {

Review Comment:
   You are passing a long value which is representing some numerical value (containers, memory MB, vcores) so the name of the parameter should represent it correctly. I suggest 'value' as it's generic enough. 
   'appInfoFunc' is not correct as the values you are passing are not functions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org